Clean code for potemplates +admin form next_url
Bug #526998 reported by
Adi Roiban
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Adi Roiban |
Bug Description
Since the potemplate +admin form can be accessed from both series/+templates page and from the potemplates index page the form is using HTTP_REFERER for choosing the next_url.
Since +admin form can rename the template, the previous URL is no longer valid and this is why things are more complicated.
As on MP 19395 (https:/
Related branches
lp:~adiroiban/launchpad/bug-522188-take-2
Merged
into
lp:launchpad
- Graham Binns (community): Approve (code)
-
Diff: 194 lines (+47/-61)5 files modifiedlib/canonical/launchpad/templates/launchpad-form.pt (+10/-1)
lib/canonical/launchpad/webapp/launchpadform.py (+30/-1)
lib/lp/app/templates/generic-edit-next-url.pt (+0/-19)
lib/lp/translations/browser/configure.zcml (+2/-2)
lib/lp/translations/browser/potemplate.py (+5/-38)
Changed in rosetta: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: tech-debt |
tags: | removed: cleanup |
Changed in rosetta: | |
assignee: | nobody → Adi Roiban (adiroiban) |
tags: |
added: qa-ok removed: qa-needstesting |
To post a comment you must log in.
Fixed in stable r10524 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 10524>