review type is not exposed in the API

[Daniel Holbach]

In [1]: p = launchpad.people["ubuntu-branches"]

In [2]: a = p.getRequestedReviews(status="Needs review")

In [3]: r = a[0]

In [4]: r.lp_attributes
Out[4]:
['self_link',
 'resource_type_link',
 'http_etag',
 'queue_status',
 'private',
 'date_reviewed',
 'date_review_requested',
 'commit_message',
 'queue_position',
 'date_merged',
 'reviewed_revno',
 'address',
 'queued_revno',
 'date_queued',
 'merged_revno',
 'date_created']

In [5]: r.lp_entries
Out[5]:
['queuer',
 'source_branch',
 'reviewer',
 'registrant',
 'target_branch',
 'preview_diff',
 'supersedes',
 'prerequisite_branch',
 'superseded_by',
 'merge_reporter']

In [6]: r.lp_collections
Out[6]: ['votes', 'all_comments']

In [7]: r.lp_operations
Out[7]:
['getComment',
 'nominateReviewer',
 'updatePreviewDiff',
 'createComment',
 'setStatus']

[Tim Penhey (thumper)]

What do you mean by review type?

[Daniel Holbach (dholbach)]

Check out https://code.launchpad.net/~dholbach/harvest/feature/+merge/19872 - table in the middle, second column. In this case it's not set.

[Tim Penhey (thumper)]

On Thu, 25 Feb 2010 20:09:34 Daniel Holbach wrote:
> Check out
> https://code.launchpad.net/~dholbach/harvest/feature/+merge/19872 -
> table in the middle, second column. In this case it's not set.
>

Actually it is, just not very intuitive I think.

You need to go through the votes attribute of the merge proposal. This then
has:
  reviewer
  review_type
  comment (if they have commented, if it is None it is Pending)

[Daniel Holbach (dholbach)]

Oh ok. Sorry for the noise then.

[Martin Pool (mbp)]

Maybe this should go into the api documentation on help.l.n, perhaps in a faq?

--
Martin <http://launchpad.net/~mbp/>

[Tim Penhey (thumper)]

On Thu, 25 Feb 2010 23:00:01 Martin Pool wrote:
> Maybe this should go into the api documentation on help.l.n, perhaps in
> a faq?

Yes, it should.

[Martin Pool (mbp)]

I'd like to add it, but https://help.launchpad.net/API is locked. :-(

kfogel has an RT open to change this.

[Jonathan Lange (jml)]

On Thu, Feb 25, 2010 at 9:22 PM, Martin Pool <email address hidden> wrote:
> I'd like to add it, but https://help.launchpad.net/API is locked. :-(
>
> kfogel has an RT open to change this.

You could also put it on https://help.launchpad.net/API/Examples --
you should have access to that.

jml

[Martin Pool (mbp)]

On 27 February 2010 00:15, Jonathan Lange <email address hidden> wrote:
> On Thu, Feb 25, 2010 at 9:22 PM, Martin Pool <email address hidden> wrote:
>> I'd like to add it, but https://help.launchpad.net/API is locked. :-(
>>
>> kfogel has an RT open to change this.
>
> You could also put it on https://help.launchpad.net/API/Examples --
> you should have access to that.

Done, refinements welcome. Let's start doing this when someone asks
about how to use the API.

--
Martin <http://launchpad.net/~mbp/>