Preview diff generation should not happen when target branch is not mirrored
Bug #525849 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
Bug Description
While we've handled the case where the source branch hasn't been pushed, we don't seem to have handled the case where the target branch hasn't been pushed. This means that we can get errors like OOPS-1512UPD7. We should probably not be creating the update preview diff jobs at all if the target is not a branch, and then create one when the target becomes a branch.
Related branches
lp:~abentley/launchpad/unready-target
- Gavin Panella (community): Approve (code)
-
Diff: 81 lines (+15/-5)3 files modifiedlib/lp/code/model/branch.py (+2/-1)
lib/lp/code/model/tests/test_branch.py (+12/-4)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+1/-0)
| tags: | added: oops |
| Changed in launchpad-code: | |
| status: | Triaged → Fix Committed |
| status: | Fix Committed → In Progress |
| assignee: | nobody → Aaron Bentley (abentley) |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.03 |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10490 <http://