ENSURE-DIRECTORY-PATHNAME breaks logical pathnames

[Robert P. Goldman]

ENSURE-DIRECTORY-PATHNAME can turn a valid logical pathname string into an invalid pathname. Here is an example:

Here is a transcript (from ACL) showing lossage with ENSURE-DIRECTORY-PATHNAME:

[1] ASDF(26): (probe-file "home:lisp;asdf;")
#P"/Users/rpg/lisp/asdf/"
[1] ASDF(27): (probe-file (ensure-directory-pathname (eval "home:lisp;asdf;")))
NIL
[1] ASDF(28): (ensure-directory-pathname (eval "home:lisp;asdf;"))
#P"home:lisp;asdf;/"
[1] ASDF(29): (probe-file (eval "home:lisp;asdf;"))
#P"/Users/rpg/lisp/asdf/"
[1] ASDF(30):

Same undesirable behavior on SBCL:

ASDF> (ensure-directory-pathname (eval "home:lisp;asdf;"))
#P"home:lisp;asdf;/"

We must check the pathname and attempt to determine if it is a logical pathname before we go slamming a "/" on the end of it.

This is a regression --- ASDF used to handle logical pathnames in the central registry correctly.

[Robert P. Goldman (rpgoldman)]

Patch committed, but not extensively tested. We should probably have a small test suite for ENSURE-DIRECTORY-PATHNAME.

[Faré (fahree)]

I fixed this by essentially reverting to some ugly but more portable previous ASDF 1 code in 1.653.