Moving the reviewer option in to the expander leads to people requesting more than they want

[James Westby]

Hi,

The reviewer option for creating a merge proposal has moved in to the
expander, but it appears no-one opens that or knows it is available.

In addition it seems that wanting to request a review from someone specific
isn't as rare as I might have thought.

Combining these two things means that we are getting a few merge proposals
created with too many reviewers, as the proposer creates one and gets the default,
then requests the extra reviews, and ends up with more requests than they want.

I would suggest that the option move back out from the expander, as it is pre-filled
there isn't too much extra load on the proposer by having it there.

Thanks,

James

[Tim Penhey (thumper)]

James, do you think the review type should be moved back out as well?

  status triaged
  importance medium
  tag udd
  tag confusing-ui
  tag trivial
  tag code-review

[James Westby (james-w)]

On Sun, 21 Feb 2010 20:12:39 -0000, Tim Penhey <email address hidden> wrote:
> James, do you think the review type should be moved back out as well?

Possibly, as it could be seen as a pair.

I've not seen the review type used much on Ubuntu branches (at least so
far), and when not clearly marked as optional it causes confusion.

So, I don't mind it moving back if you think it is a good idea, provided
it is clearly marked as optional.

Thanks,

James

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12125 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12125>.