Source package shows historic upstream

[Curtis Hovey]

The source package page uses the historic packaging object when there is no packaging link for the current series. This makes it impossible to create the packaging link for the current series (you can only edit the historic one). This also causes misunderstandings where https://edge.launchpad.net/ubuntu/lucid/+needs-packaging correctly shows what information is missing, but when the user visits the SP page, the information appears to be set.

Old erroneous description of the root cause:
https://edge.launchpad.net/ubuntu/lucid/+needs-packaging includes gtk+2.0 and alacarte, both of which are already associated with upstream projects. Since these are not appearing in +packaging, something in the base queries used by both views is wrong.

[Curtis Hovey (sinzui)]

The report is correct. The SP UI is lying. The page is using the packaging link from karmic because lucid does not have one. It is not clear from the UI that a guess is being made.

This behaviour is historic. The initialize-from-parent script did not copy packaging links forward, so the UI would guess at the correct packaging link. This proved to be problematice because without a proper representation of the state in the schema, it was difficult to know the true state of packaging, and Launchpad often (such as in this very case) contradicts itself.

The correct behaviour is to remove the guess logic. Instead, the UI can ensure that the previous upstream project is in the list of projects that the sp page will propose. The page should also make it easy to see what the previous upstream project was. Users will rarely need to set this because the initialize-from-parent does copy the packaging links from the parent series to the current series.

[Curtis Hovey (sinzui)]

sp.productseries needs to use sp.direct_packaing so that the correct packaging entry is selected. direct_packaing should use selectOneBy() so that an oops is reported if there is a data integrity problem.

[Curtis Hovey (sinzui)]

Fixed released in launchpad-project 10.02.