Attachments sent by the BranchMergeProposal mailer are bad
Bug #522954 reported by
Tim Penhey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Tim Penhey |
Bug Description
The filename and content type are screwed.
Related branches
lp:~thumper/launchpad/code-review-email-attachment-fix
- Michael Hudson-Doyle: Approve
-
Diff: 31 lines (+9/-1)2 files modifiedlib/lp/code/mail/codereviewcomment.py (+1/-1)
lib/lp/code/mail/tests/test_codereviewcomment.py (+8/-0)
tags: | added: trivial |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 10.02 |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Could you be more specific about this?
The filename is review.diff.txt so that it will appear inline in gmail. The content-type is text/x-diff so that reasonable mailers will handle it as a patch. What's the problem?