Template +edit and +admin forms should use referrer in next_url

[Adi Roiban]

In the merge review for bug 340664, Curtis noted that the next_url for potemplate edit and admin forms is not using the referer address.

Below are his comments:

The behaviour of these actions is disconcerting. When I edit a a template,
the next_url is the template, but I expected to return to the all templates
view. I know that this behaviour has not changed in this branch. I do not
see any bugs that pertain to this surprise--maybe I do not know what to
search on. Here is an example of how to negotiate multiple origins:

    @property
    def next_url(self):
        referrer = self.request.getHeader('referer')
        if (referrer is not None
            and referrer.startswith(self.request.getApplicationURL())):
            return referrer
        else:
            return canonical_url(self.context)

[Ursula Junque (ursinha)]

Fixed in stable r10497 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10497>

[Adi Roiban (adiroiban)]

The referrer redirect is not working if product, series or sourcepackage name contains the template name.
This bug will also need unit tests.

[Curtis Hovey (sinzui)]

Edwin landed a redirect/next_url mixin that views can use. This bug may be fixable by switching to the mixin

[Adi Roiban (adiroiban)]

Thanks Curtis for this notice.

I have extended the ReturnToReferrerMixin mixin implemented by Edwin to handle the case when the form action can render the referrer url invalid.

[Ursula Junque (ursinha)]

Fixed in stable r10524 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10524>

[Curtis Hovey (sinzui)]

Fixed released in launchpad-project 10.03.