Inkscape

Patch to allow inkscape to be built for windows 64-bit

Bug #520527 reported by Fridrich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
Krzysztof Kosinski
Inkscape 0.48 "0.48"

Bug Description

Inkscape needs some changes to be able to be built as native win64 binary. The attached patch allows that.

Tags: build win32

Related branches

lp:inkscape/0.48.x
Revision history for this message
Fridrich (fridrich-strba) wrote :
Revision history for this message
jazzynico (jazzynico) wrote :

Krzysztof, could you please take a look at this patch?

tags: added: build win32
Changed in inkscape:
assignee: nobody → Krzysztof Kosinski (tweenk)
Revision history for this message
Krzysztof Kosinski (tweenk) wrote :

I don't like the #ifdef _WIN64 bit. It should use HINSTANCE. The double-casts to long are also unnecessary - casting to size_t is probably enough to get the correct enum values. Otherwise it looks OK, will apply soon.

Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

Yes, the use of that #ifdef needs to be replaced with HINSTANCE.

One big item we should take care with is casts. Instead of c-style casts be sure to use the appropriate C++ casts.

su_v (suv-lp)
Changed in inkscape:
status: New → In Progress
Krzysztof Kosinski (tweenk)
Changed in inkscape:
status: In Progress → Fix Committed
Krzysztof Kosinski (tweenk)
Changed in inkscape:
milestone: none → 0.48
Krzysztof Kosinski (tweenk)
Changed in inkscape:
importance: Undecided → Low
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.