+editpgpkeys can have an action that is not a string
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Brad Crittenden |
Bug Description
OOPS-1502N4471 shows that getattr(self, action) was called and the action was not a string, it is None.
PersonGPGView.
def form_action(self):
if self.request.method != "POST":
return ''
action = self.request.
if action and (action not in permitted_actions):
raise UnexpectedFormD
I cannot see how this happened, but for the view to work as we intend, it should do:
if action not in permitted_actions:
raise UnexpectedFormD
Related branches
- Curtis Hovey (community): Approve (code)
-
Diff: 69 lines (+20/-12)2 files modifiedlib/lp/registry/browser/person.py (+9/-5)
lib/lp/registry/browser/tests/gpg-views.txt (+11/-7)
Changed in launchpad-registry: | |
milestone: | none → series-10.05 |
Changed in launchpad-registry: | |
status: | Triaged → In Progress |
assignee: | nobody → Brad Crittenden (bac) |
Changed in launchpad-registry: | |
milestone: | series-future → 10.05 |
Changed in launchpad-registry: | |
status: | In Progress → Fix Committed |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
Fixed in stable r10904 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 10904>