Launchpad itself

Make use of the Bug.latest_patch_uploaded when searching for bugs with patches

Bug #520474 reported by Eleanor Berger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Eleanor Berger
Launchpad itself 10.02

Bug Description

The new column Bug.latest_patch_uploaded pre-calculates the value. Using it is much faster than running a subquery, so we should make use of it whenever we can. One such place is the search for bugs with patches (bugs for which that column is not null). It can also serve as the implementation for IBug.has_patches.

Related branches

lp:~intellectronica/launchpad/optimize-patch-search
Abel Deuring (community): Approve (code)
Diff: 1860 lines (+1506/-167)
14 files modified
Makefile (+11/-2)
buildout-templates/bin/combine-css.in (+2/-2)
buildout-templates/bin/sprite-util.in (+43/-0)
lib/canonical/launchpad/browser/vocabulary.py (+1/-1)
lib/canonical/launchpad/icing/icon-sprites.positioning (+472/-0)
lib/canonical/launchpad/icing/style-3-0.css.in (+491/-132)
lib/lp/app/browser/tests/base-layout.txt (+7/-8)
lib/lp/app/templates/base-layout-macros.pt (+1/-1)
lib/lp/bugs/model/bug.py (+1/-7)
lib/lp/bugs/model/bugtask.py (+12/-14)
lib/lp/services/doc/sprites.txt (+185/-0)
lib/lp/services/spriteutils.py (+243/-0)
lib/lp/services/tests/test_doc.py (+17/-0)
lib/lp/services/tests/testfiles/template.css (+20/-0)
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in db r9008 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-devel/revision/9008>

Changed in malone:
status: In Progress → Fix Committed
Eleanor Berger (intellectronica)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.