fix for "#502673 gui becomes unresponsive" breaks compilation

[joaocorreia123]

the submitted fix for "#502673 gui becomes unresponsive",
which is:

" 349. By Steven Sheehy on 2010-02-02
    Fixed an issue with the GUI randomly freezing"

breaks compilation, at least on my fedora/rawhide box. It bombs about XFlush dependency (libX11) not being found. I believe its just a matter of scons not checking/configuring for it, but i'm no expert. Reverting #349 brings back compilation just fine. (It should also reintroduce the #502673 bug again, although i've never been hit by it anyway.)

Thank you,
Joao

[Complete compilation log attached, disregard the warnings, as these are harmless, the error is at the end.]

Error message:
"g++ -o linuxdcpp -Wl,--as-needed -pthread build/dcpp/libdcpp.a build/gui/search.o build/gui/WulforUtil.o build/gui/favoritehubs.o build/gui/privatemessage.o build/gui/hashdialog.o build/gui/settingsdialog.o build/gui/wulformanager.o build/gui/mainwindow.o build/gui/dialogentry.o build/gui/transfers.o build/gui/wulfor.o build/gui/publichubs.o build/gui/sharebrowser.o build/gui/hub.o build/gui/finishedtransfers.o build/gui/bookentry.o build/gui/entry.o build/gui/downloadqueue.o build/gui/settingsmanager.o build/gui/UserCommandMenu.o build/gui/treeview.o -L/lib -Lbuild/dcpp -Ldcpp -ldcpp -lz -lbz2 -lcrypto -lssl -lnotify -ldbus-glib-1 -ldbus-1 -lpthread -lglade-2.0 -lgtk-x11-2.0 -lxml2 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0
/usr/bin/ld: build/gui/wulformanager.o: undefined reference to symbol 'XFlush'
/usr/bin/ld: note: 'XFlush' is defined in DSO /usr/lib/libX11.so.6 so try adding it to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
scons: *** [linuxdcpp] Error 1"

[Steven Sheehy (steven-sheehy)]

Added X11 to linking flags. Strange that it wasn't needed on my system.

[joaocorreia123 (joaomiguelcorreia)]

Confirmed fixed.

Thank you,
Joao

[vivek (vivek-keshri-mail)]

Can you please explain how to add X11 to linking flags

[Steven Sheehy (steven-sheehy)]

Not sure why you'd need to do this, we've released 1.1.0 which has this fix in it already. If for whatever reason you can't get binaries for your distro and need to compile from source, then you should at least get the source for 1.1.0 (https://launchpad.net/linuxdcpp/+download). If you still want to add X11 manually, then take a look at the commit that fixed it:

http://bazaar.launchpad.net/~linuxdcpp-team/linuxdcpp/trunk/revision/350

[Nehal J Wani (nehaljwani)]

I found the exact solution and one should follow these steps:

Step 1: Download Source. http://prdownload.berlios.de/linuxdcpp/linuxdcpp-1.0.2.tar.bz2

Step 2: Install the packages required for compilation of source code.

 yum install scons zlib-devel bzip2-devel openssl-devel libglade2-devel gtk2-devel gcc-c++

This will take time depending upon the number of dependencies.

Step 3: Edit the file SConstruct and add the following:

    if not conf.CheckLib('X11'):
                 print '\tX11 library not found'
                 Exit(1)

Step 4: Compile!

    scons install

This will take time depending upon your system

Step 5: Now that linuxdcpp has been installed, I'll show you a [demo](http://www.youtube.com/watch?v=t0WryAKW2PI).