time-admin crashed with SIGSEGV in strchr()

[Robert Moerland]

Binary package hint: gnome-system-tools

The 'Time and Date' settings manager crashed when I tried to add an extra NTP server by typing the URL of the server in the text entry box, and then pressing the 'Add' button.

ProblemType: Crash
Architecture: i386
Date: Wed Feb 10 23:43:40 2010
DistroRelease: Ubuntu 10.04
ExecutablePath: /usr/bin/time-admin
Package: gnome-system-tools 2.29.3-0ubuntu2
ProcCmdline: time-admin
ProcEnviron:
 LANGUAGE=en_US.UTF-8
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-14.48-generic
SegvAnalysis:
 Segfault happened at: 0xf8d073 <strchr+99>: mov (%eax),%ecx
 PC (0x00f8d073) ok
 source "(%eax)" (0x00000000) not located in a known VMA region (needed readable region)!
 destination "%ecx" ok
SegvReason: reading NULL VMA
Signal: 11
SourcePackage: gnome-system-tools
StacktraceTop:
 strchr () from /lib/tls/i686/cmov/libc.so.6
 on_ntp_addserver ()
 g_cclosure_marshal_VOID__VOID ()
 g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
 ?? () from /usr/lib/libgobject-2.0.so.0
Title: time-admin crashed with SIGSEGV in strchr()
Uname: Linux 2.6.31-14-generic i686
UserGroups: adm admin audio cdrom dialout dip fax floppy fuse lpadmin netdev plugdev sambashare scanner tape video

[Apport retracing service (apport)]

StacktraceTop:
 strchr () at ../sysdeps/i386/strchr.S:127
 on_ntp_addserver (widget=0x9c4f4f8, dialog=0x0)
 g_cclosure_marshal_VOID__VOID ()
 g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
 ?? () from /usr/lib/libgobject-2.0.so.0

[Milan Bouchet-Valat (nalimilan)]

Thanks for catching that one! I've been able to reproduce the crash with an up-to-date Lucid LiveCD. It happens because we've changed the way callbacks are handled, and the pointer to the dialog was invalid, which means we were using a NULL pointer for the server address.

I've just pushed a fix upstream, which should be available in Lucid with the gnome-system-tools 2.29.91. Please continue testing the gnome-system-tools in Lucid to help us making it a great release!

[Robert Moerland (veel-mail)]

You're welcome, glad to be of help :)

[Milan Bouchet-Valat (nalimilan)]

This has been uploaded to Lucid a while ago.