libnih.m4 provides incompatible AC_COPYRIGHT macro

Bug #519278 reported by ensc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libnih
Fix Released
Medium
Scott James Remnant (Canonical)

Bug Description

libnih installs a system wide libnih.m4 file which overrides the standard AC_COPYRIGHT() macro. The new macro breaks compilation of existing projects (e.g. curl) which contain multi-line copyright messages. Generated makefiles will be broken due to lines like

| PACKAGE_COPYRIGHT = Copyright ...
| This package ...

libnih should not override AC_COPYRIGHT system wide but move it into a private .m4 file which is not installed by 'make install'.

Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

Yeah, this should be NIH_COPYRIGHT I guess and call AC_COPYRIGHT as part of its implementation. It made sense when you copied nih/*.m4 into your own source trees, but not when installed globally

affects: upstart → libnih
Changed in libnih:
importance: Undecided → Medium
status: New → Triaged
status: Triaged → Fix Committed
Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :
Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

1.0.2 2010-04-27

        * AC_COPYRIGHT wrapper renamed to NIH_COPYRIGHT. (Bug: #519278)

        * Serial added to libnih.m4 to stop aclocal overwriting a local
          copy with an older installed copy.

        * NIH_WITH_LOCAL_LIBNIH macro added that can be used by external
          sources to add a --with-local-libnih configure argument.

Changed in libnih:
milestone: none → 1.0.2
assignee: nobody → Scott James Remnant (scott)
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.