Allows pushing to lp:ubuntu/lucid/package/foo or lp:ubuntu/package/foo but silently remaps that

[Loïc Minier]

Binary package hint: bzr

Hi

I was working on a bug fix starting from the Ubuntu branch lp:ubuntu/binfmt-support and decided to try pushing (I think somewhat naturally) to lp:~lool/ubuntu/binfmt-support/lp-519228. To my surprize, the bug got a link to lp:~lool/ubuntu/binfmt-support instead! I tried pushing to lp:ubuntu/lucid/binfmt-support/lp-519228 as well, and that told me "No new revisions to push." so obviously pushing to the same -- from my perspective, incorrect -- location.

Next I tried pushing to lp:ubuntu/binfmt-support/lp-519228:
bzr: ERROR: Invalid url supplied to transport: "lp:ubuntu/binfmt-support/lp-519228": No such distribution series binfmt-support.

I ended up pushing to lp:~lool/ubuntu/lucid/binfmt-support/lp-519228.

I think bzr shouldn't allow the first form of URLs (lp:ubuntu/package/foo and lp:ubuntu/series/package/foo) or should bark if these get remapped.

It would also be nice if the lp:~people/ubuntu/package/foo form was supported and not only lp:~people/ubuntu/series/package/foo.

Thanks,

ProblemType: Bug
Architecture: amd64
Date: Tue Feb 9 12:10:27 2010
DistroRelease: Ubuntu 10.04
Package: bzr 2.0.4-1
ProcEnviron:
 LANGUAGE=fr_FR.UTF-8
 PATH=(custom, user)
 LANG=fr_FR.UTF-8
 SHELL=/bin/zsh
ProcVersionSignature: Ubuntu 2.6.32-12.17-generic
SourcePackage: bzr
Uname: Linux 2.6.32-12-generic x86_64

[John A Meinel (jameinel)]

sorry about the noise, but this is the only way I found to target the bug at launchpad-code.

I believe it is an lp-code issue because that is where the policy of what branches can be placed where resides. I don't think bzr itself cares.

[Jonathan Lange (jml)]

I agree that there's definitely some buggy behaviour here, and stuff that we can improve.

However, I'm not really clear on precisely what needs to be fixed to close this bug.

[Loïc Minier (lool)]

My expectation would be either of:
- I can't create the branches because these are not supported for now, and we keep the name for later
- or I can create the branches, but there are entirely separate distro/package/topic branches for which I can request merging, review etc. and which appear on some overview page of "branches for package foobar"

I have no strong preference over either; I just wish for the short term that I wouldn't be allowed to push to a random location which gets remapped to the official branch.

I would also appreciate being able to push to lp:~lool/ubuntu/package/feature instead of requiring lp:~lool/ubuntu/lucid/package/feature since that would be consistent with the branch I started with (lp:ubuntu/package).

[James Westby (james-w)]

On Wed, 10 Feb 2010 11:08:22 -0000, Loïc Minier <email address hidden> wrote:
> My expectation would be either of:
> - I can't create the branches because these are not supported for now, and we keep the name for later
> - or I can create the branches, but there are entirely separate distro/package/topic branches for which I can request merging, review etc. and which appear on some overview page of "branches for package foobar"
>
> I have no strong preference over either; I just wish for the short term
> that I wouldn't be allowed to push to a random location which gets
> remapped to the official branch.

This is the reason I asked lool to report this bug. Pushing to

  lp:ubuntu/<package>/some-branch-name

should give you an error.

It expands to

  lp:~ubuntu-branches/ubuntu/lucid/<package>/lucid/some-branch-name

which would be refused if you tried to push to that when there wasn't
a branch at

  lp:~ubuntu-branches/ubuntu/lucid/<package>/lucid

but it suddenly becomes allowed when there is a branch there.

> I would also appreciate being able to push to
> lp:~lool/ubuntu/package/feature instead of requiring
> lp:~lool/ubuntu/lucid/package/feature since that would be consistent
> with the branch I started with (lp:ubuntu/package).

This is a seperate question. We have discussed having an alias so that
the first maps to the second. Please file another bug against
launchpad-code if you wish to discuss that.

Thanks,

James

[Loïc Minier (lool)]

Filed bug #519791 about the latter issue.

[Tim Penhey (thumper)]

On Thu, 11 Feb 2010 00:37:11 James Westby wrote:
> This is the reason I asked lool to report this bug. Pushing to
>
> lp:ubuntu/<package>/some-branch-name
>
> should give you an error.
>
> It expands to
>
> lp:~ubuntu-branches/ubuntu/lucid/<package>/lucid/some-branch-name

Hmm.. I find that very surprising. I agree that it should not be allowed.

[Aaron Bentley (abentley)]

I cannot reproduce this issue.

In my testing, all attempts to use the URL lp:~lool/ubuntu/binfmt-support/lp-519228 produce the error:
bzr: ERROR: Invalid url supplied to transport: "lp:~lool/ubuntu/binfmt-support/lp-519228": No such distribution series binfmt-support.