lp-mirror breaks on branches that are not mirrors

[Jelmer Vernooij]

  affects bzr

charis:~/src/bzr-rewrite/trunk% bzr lp-mirror lp:bzr-rewrite
bzr: ERROR: lazr.restfulclient.errors.HTTPError: HTTP Error 400: Bad
Request
Response headers:
---
connection: close
content-length: 31
content-type: text/plain
date: Mon, 08 Feb 2010 12:55:14 GMT
server: zope.server.http (HTTP)
status: 400
vary: Cookie,Authorization,Accept
via: 1.1 wildcard.edge.launchpad.net
x-powered-by: Zope (www.zope.org), Python (www.python.org)
---
Response body:
---
url: Required input is missing.
---

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 853,
in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 1055,
in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 661,
in run_argv_aliases
    return self.run_direct(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 665,
in run_direct
    return self._operation.run_simple(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/cleanup.py", line 122,
in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/cleanup.py", line 156,
in _do_with_cleanups
    result = func(*args, **kwargs)
  File
"/usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad/__init__.py",
line 273, in run
    lp_branch = lp_api.load_branch(launchpad, branch)
  File
"/usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad/lp_api.py",
line 132, in load_branch
    lp_branch = launchpad.branches.getByUrl(url=url)
  File "/usr/lib/pymodules/python2.5/lazr/restfulclient/resource.py",
line 476, in __call__
    url, in_representation, http_method, extra_headers=extra_headers)
  File "/usr/lib/pymodules/python2.5/lazr/restfulclient/_browser.py",
line 217, in _request
    raise HTTPError(response, content)
HTTPError: HTTP Error 400: Bad Request
Response headers:
---
connection: close
content-length: 31
content-type: text/plain
date: Mon, 08 Feb 2010 12:55:14 GMT
server: zope.server.http (HTTP)
status: 400
vary: Cookie,Authorization,Accept
via: 1.1 wildcard.edge.launchpad.net
x-powered-by: Zope (www.zope.org), Python (www.python.org)
---
Response body:
---
url: Required input is missing.
---

bzr 2.1.0rc2 on python 2.5.5
(Linux-2.6.32-trunk-amd64-x86_64-with-debian-squeeze-sid)
arguments: ['/usr/bin/bzr', 'lp-mirror', 'lp:bzr-rewrite']
encoding: 'ANSI_X3.4-1968', fsenc: 'ANSI_X3.4-1968', lang: 'C'
plugins:
  builddeb /home/jelmer/.bazaar/plugins/builddeb [2.2.0]
  bzrtools /home/jelmer/.bazaar/plugins/bzrtools [2.1.0]

cvsps_import /usr/lib/python2.5/site-packages/bzrlib/plugins/cvsps_import [unknown]

dbus /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus [0.1.0dev]

email /usr/lib/python2.5/site-packages/bzrlib/plugins/email [unknown]

etckeeper /usr/lib/python2.5/site-packages/bzrlib/plugins/etckeeper [unknown]

fastimport /usr/lib/python2.5/site-packages/bzrlib/plugins/fastimport [0.9.0dev]
  git /home/jelmer/.bazaar/plugins/git [0.4.4dev]

gtk /usr/lib/python2.5/site-packages/bzrlib/plugins/gtk
[0.98.0dev1]
  hg /home/jelmer/.bazaar/plugins/hg [0.2.0dev]
  jelmer /home/jelmer/.bazaar/plugins/jelmer [unknown]

launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [2.1.0rc2]

loggerhead /usr/lib/python2.5/site-packages/bzrlib/plugins/loggerhead [1.17.0]

loom /usr/lib/python2.5/site-packages/bzrlib/plugins/loom [1.4.0dev]
  lpreview_body /home/jelmer/.bazaar/plugins/lpreview_body
[unknown]
  mirrors /home/jelmer/.bazaar/plugins/mirrors [unknown]

netrc_credential_store /usr/lib/python2.5/site-packages/bzrlib/plugins/netrc_credential_store [2.1.0rc2]

news_merge /usr/lib/python2.5/site-packages/bzrlib/plugins/news_merge [2.1.0rc2]

pqm /usr/lib/python2.5/site-packages/bzrlib/plugins/pqm
[1.4.0dev]
  qbzr /home/jelmer/.bazaar/plugins/qbzr [0.15.0dev]
  rebase /home/jelmer/.bazaar/plugins/rebase [0.5.5]

search /usr/lib/python2.5/site-packages/bzrlib/plugins/search [1.7.0dev]

stats /usr/lib/python2.5/site-packages/bzrlib/plugins/stats [0.1.0dev]
  svn /home/jelmer/.bazaar/plugins/svn [1.0.3dev]
  update_copyright /home/jelmer/.bazaar/plugins/update_copyright
[unknown]

upload /usr/lib/python2.5/site-packages/bzrlib/plugins/upload [1.0.0dev]
  zeitgeist /home/jelmer/.bazaar/plugins/zeitgeist [unknown]

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.
charis:~/src/bzr-rewrite/trunk%

[Martin Pool (mbp)]

It also seems to break if you give it a non-lp url.