Add an extra import status for when approval is not possible.
Bug #516739 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Henning Eggers | ||
Bug Description
When we cannot approve an import for some reason, it is currenty left in "Needs Review". It would be much better, if the entry could simply be set to "Needs information".
Related branches
lp:~henninge/launchpad/bug-516739-needs-information
- Jeroen T. Vermeulen (community): Approve (code)
-
Diff: 201 lines (+40/-25)6 files modifiedlib/canonical/launchpad/icing/style-3-0.css (+2/-0)
lib/lp/translations/doc/translationimportqueue.txt (+1/-0)
lib/lp/translations/interfaces/translationimportqueue.py (+6/-0)
lib/lp/translations/model/translationimportqueue.py (+4/-0)
lib/lp/translations/stories/importqueue/xx-translation-import-queue-filtering.txt (+1/-0)
lib/lp/translations/tests/test_translationimportqueue.py (+26/-25)
| summary: |
- Make "Failed" import status usable for approval errors. + Add an extra import status for when approval is not possible. |
| description: | updated |
Revision history for this message
| Henning Eggers (henninge) wrote | #2 |
| Changed in rosetta: | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Henning Eggers (henninge) |
| milestone: | none → 10.02 |
Revision history for this message
| Ursula Junque (ursinha) wrote A commit mentioned this bug | #3 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 516739 Fix released | #4 |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Maybe an extra state "Rejected" or "Failed Review" would be good, too.