Product:+changetranslators should become +settings

Bug #516317 reported by Данило Шеган
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Данило Шеган

Bug Description

Product translation page has a link to change permissions, and that link also takes one to set the translation focus series for a product. We should turn the page into "+settings", and make sure the link that takes people there indicates it's more than just permissions.

Related branches

Changed in rosetta:
assignee: nobody → Данило Шеган (danilo)
status: Triaged → In Progress
Revision history for this message
Adi Roiban (adiroiban) wrote :

In a preimplementation chat for bug 127171, Jeroen and I talked about renaming +changetranslators to +translations-policy .

We already have the „+translations-setting” in ISeries for setting translations import and export and the ideas was to name it „translations-policy” to avoid a confusion between +settings and +translations-settings

For solving bug 127171, I already did the renaming and also updated all tests.

It is ok to do the renaming togheter with but 127171, or we should fix this problem in a different branch ?

Revision history for this message
Adi Roiban (adiroiban) wrote :

To avoid conflicts, I have renamed the link to +settings in the branch for bug 127171.

Not sure if this is the right place to add this comment.

In the same branch I have also updated the link from lib/lp/translations/templates/hastranslationgroup-portlet-translation-groups-and-permission.pt using Launchpad menu and link formatters as Curtis taught me.

It would be nice to update „Change permissions” text to something like „Translation settings”

If more attributes are going to be added to the settings page, it would be nice to move the translation-policy and translation-focus pagetests in the same folder.

Revision history for this message
j.c.sackett (jcsackett) wrote :

Just a note, there is a bug for having clearer "enabled" settings on translations, including the recently added translations_usage that has replaced official_rosetta. It's bug 646101, and I believe it may be related to this, if the intent is a general "settings" page.

Revision history for this message
Robert Collins (lifeless) wrote :

07:15 < dothebart> hm, looking at... https://help.launchpad.net/Translations/YourProject/ChoosingAGroup
07:15 < dothebart> To choose Launchpad Translators, or any other existing translation group, visit https://translations.launchpad.net/<your-project>/+changetranslators.
07:15 < dothebart> https://translations.launchpad.net/citadel/+changetranslators
07:15 < dothebart> gives me page not found?
07:19 < dothebart> and... https://help.launchpad.net/Translations/YourProject/ChoosingAGroup Once people start using Launchpad to translate your project, you'll want to export those translations for use in your software.
07:19 < dothebart> https://help.launchpad.net/Translations/YourProject/Exporting
07:19 < dothebart> doesn't exist
07:25 < dothebart> ah. https://translations.launchpad.net/citadel/+settings is the right link?

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Changed in launchpad:
milestone: none → 11.01
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.