Invalid external_dependencies can kill buildd-manager

[Julian Edwards]

An buggy external dependencies line recently caused the buildd-manager to continually fail its scan, because the "series" substitution was specified as %(series) instead of %(series)s

We should disable the PPA if there is an exception when processing external_dependencies, and continue.

[Julian Edwards (julian-edwards)]

In adapters/archivedependencies.py, in the function get_sources_list_for_building(), it should catch any exceptions when processing build.archive.external_dependencies.

I'm not sure how we can make the buildd-manager ignore the current build, but that should happen when disabling the PPA.

[LaMont Jones (lamont)]

pretty much any exception handling a ppa should just disable the ppa, instead of build-manager. :-(

[Julian Edwards (julian-edwards)]

On Tuesday 02 February 2010 18:14:55 LaMont Jones wrote:
> pretty much any exception handling a ppa should just disable the ppa,
> instead of build-manager. :-(
>

Sometimes it's just a bad build, so a blanket rule like this won't work. We
need to be more intelligent about the kinds of errors that happen.

[Muharem Hrnjadovic (al-maisan)]

> I'm not sure how we can make the buildd-manager ignore the current
> build, but that should happen when disabling the PPA.
Since the external dependencies are incorrect there's a high chance that
the current build will fail.
Any other pending builds associated with the PPA in question will be
suspended (and hence ignored by the buildd manager) as soon as the PPA
is disabled.

[Muharem Hrnjadovic (al-maisan)]

The branch that fixes this bug was tested on mawson and the effects
observed are as follows: when a candidate build job targeting a PPA with
a garbled 'external_dependencies' property is considered for dispatch
the
- PPA gets disabled
- buildd manager does dispatch the job. That's not optimal
  *but* not that bad in practical terms either because
  - that job is bound to fail early on due to unsatisfied external
    dependencies
  - even if the job builds OK the resulting binaries will fail to upload
    since the PPA was disabled in the meantime
- buildd manager does not fall over

[Diogo Matsubara (matsubara)]

Fixed in devel r10410 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/10410>