CRUD List sort broken

[koziolek]

Play Framework 1.0 b833

Steps to reproduce:
1. Create new application.
2. Add some Model class (my is MyModel/).
3. Activate CRUD module and configure it (my is admin/).
4. Create CRUD controller without any methods (my is mymodels).
5. Open CRUD panel for your model class and add some new objects.
6. Open admin/mymodels/ and try to sort list od objects.

List is always sort by Id DESC.

Source of problem:
in file CRUD.java lines 236-238:
if (orderBy == null) {
    orderBy = "id";
    order = "DESC";
}

If orderBy param is null in request then list is sort by Id DESC. It is wrong because controller doesn't allow to define order param and not define orderBy param.

Solution:
change lines to:
if (orderBy == null && order == null) {
    orderBy = "id";
    order = "ASC";
}

if (orderBy == null && order != null) {
    orderBy = "id";
}

First conditional provides situation when we not add orderBy and order params. In this situation controller set natural id ordering.
Second conditional provides situation when we add order but not add orderBy param. In this situation controller order by id use ordering defined in order parameter.

[Guillaume Bort (guillaume-bort)]

I can't reproduce it. Works for me.

[Guillaume Bort (guillaume-bort)]

Ah ok I see the bug, sorry.