Invalid New-Email Token Causes Traceback

Bug #514459 reported by Julien Funk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical SSO provider
Fix Released
Low
Ricardo Kirkner

Bug Description

1. Log into SSO
2. Add new email
3. Use the verify email link on the email that appears below
4. Then use the delete link next to the verify link
5. Go to your email box and while still logged into SSO, use the token provided in the email

You should at this point see a backtrace.

Changed in canonical-identity-provider:
importance: Undecided → Low
Changed in canonical-identity-provider:
status: New → Confirmed
Revision history for this message
Stuart Metcalfe (stuartmetcalfe) wrote :

We should just detect this case and raise a 404 exception. Set to low priority as the behaviour described would not be expected to work anyway. The issue is merely a difference in the way we report the problem. This is also likely to be a fairly rare occurence.

Changed in canonical-identity-provider:
milestone: none → 2.1.2
milestone: 2.1.2 → 2.3.0
Changed in canonical-identity-provider:
assignee: nobody → Ricardo Kirkner (ricardokirkner)
status: Confirmed → In Progress
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

Notes to QA:

Follow the steps in the bug description, and instead of getting a traceback you should get a Page Not Found error (404).

Changed in canonical-identity-provider:
status: In Progress → Fix Committed
Dave Morley (davmor2)
Changed in canonical-isd-qa:
assignee: nobody → Dave Morley (davmor2)
status: New → In Progress
Revision history for this message
Dave Morley (davmor2) wrote :

I'm getting the ugly debug 404 rather than the nice one. is this just because it's on ec2?

Page not found (404)
Request Method: GET
Request URL: http://ec2-204-236-252-189.compute-1.amazonaws.com/token/spnXq6kWz1B84BH7Q8Xt/+newemail

No EmailAddress matches the given query.

You're seeing this error because you have DEBUG = True in your Django settings file. Change that to False, and Django will display a standard 404 page.

Changed in canonical-isd-qa:
status: In Progress → Incomplete
Revision history for this message
Dave Morley (davmor2) wrote :

Had a quick chat with Ricardo this is most likely due to it being on ec2 so something to double check on staging/production.

Changed in canonical-isd-qa:
status: Incomplete → Fix Committed
Dave Morley (davmor2)
Changed in canonical-isd-qa:
status: Fix Committed → In Progress
Revision history for this message
Dave Morley (davmor2) wrote :

Passes on staging. Results in 404 error from django.

Changed in canonical-isd-qa:
status: In Progress → Fix Committed
Dave Morley (davmor2)
Changed in canonical-isd-qa:
status: Fix Committed → In Progress
Dave Morley (davmor2)
Changed in canonical-isd-qa:
status: In Progress → Fix Released
Danny Tamez (zematynnad)
Changed in canonical-identity-provider:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.