Merge emails blow my mind

Bug #5140 reported by Brad Bollenbach
2
Affects Status Importance Assigned to Milestone
Bazaar
Invalid
Wishlist
Unassigned
bzr email commit hook
Triaged
Wishlist
Unassigned

Bug Description

The merge email contains an amazing amount of useless information. Here's an example:

 De : <email address hidden>
 Objet : Rev 2859: [r=BjornT] add a 'priority' sub-command to the email UI in /home/pqm/arch/queue/workdir/home/---devel/launchpad
 Date : November 28, 2005 1:10:56 PM EST (CA)
 À : <email address hidden>
 Répondre à : <email address hidden>

------------------------------------------------------------
revno: 2859
revision-id: <email address hidden>
parent: <email address hidden>
parent: <email address hidden>
committer: Canonical.com Patch Queue Manager<email address hidden>
timestamp: Mon 2005-11-28 18:09:09 +0000
message:
  [r=BjornT] add a 'priority' sub-command to the email UI
modified:
  lib/canonical/launchpad/doc/emailinterface.txt x_Bjorn_Tillenius_<email address hidden>_Wed_Mar_30_10:52:42_2005_7337.0
  lib/canonical/launchpad/mail/commands.py x_Bjorn_Tillenius_<email address hidden>_Mon_May_16_18:11:36_2005_15009.0
    ------------------------------------------------------------
    merged: <email address hidden>
    parent: <email address hidden>
    parent: <email address hidden>
    committer: Brad Bollenbach <email address hidden>
    timestamp: Mon 2005-11-28 12:12:44 -0500
    message:
      merge from rf, resolving conflicts
    ------------------------------------------------------------
    merged: <email address hidden>
    parent: <email address hidden>
    committer: Brad Bollenbach <email address hidden>
    timestamp: Fri 2005-11-25 17:03:39 -0500
    message:
      add a 'priority' email sub-command to the Malone email UI

--
arch-commits mailing list
<email address hidden>
http://lists.canonical.com/mailman/listinfo/arch-commits

Out of this entire blob of information I'm bombarded with, only the Subject line is actually useful, and even then, only half of that, the "Rev 2859: [r=BjornT] add a 'priority' sub-command to the email UI" bit.

I would suggest that all this information be removed from merge mails, unless I explicitly ask for insane verbosity. There are exactly two things I care very much about in a merge notification:

1. The summary message, including who made the change, of course.
2. The diff.

Changed in pqm:
status: New → Rejected
Revision history for this message
Brad Bollenbach (bradb) wrote : Re: [Bug 5140] Merge emails blow my mind

Le 28-Nov-05 à 4:21 PM, Robert Collins a écrit :

> Public bug report changed:
> https://launchpad.net/malone/bugs/5140
>
> Changed in: PQM (upstream)
> Status: New => Rejected
> Explanation: This is not something PQM knows about - notification
> emails are driven by bzr.

I wouldn't have guessed that initially, but now that seems to make
sense.

Wouldn't it make more sense to retarget this to the bzr product
though, or are you suggesting that my confusion is unwarranted?

Cheers,

--
Brad Bollenbach

Revision history for this message
Christian Reis (kiko) wrote :

I agree the mails are terribly noisy.

Changed in pqm:
status: Rejected → New
Revision history for this message
Robert Collins (lifeless) wrote :

Patches are welcome for this, there is no doubt that the output can be improved - options would be nice.

Changed in bzr:
status: Unconfirmed → Confirmed
Revision history for this message
Aaron Bentley (abentley) wrote :

PQM is written in Python, so it can output whatever it pleases. I don't think this bug has anything to do with Bazaar.

Revision history for this message
Martin Pool (mbp) wrote :

Is this coming from pqm, or from the bzr-email plugin?

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 5140] Re: Merge emails blow my mind

On Tue, 2007-09-11 at 23:58 +0000, Martin Pool wrote:
> Is this coming from pqm, or from the bzr-email plugin?

bzr-email, as already noted in the bug history IIRC.

Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Martin Pool (mbp) wrote :

The bug is in bzr-email, not bzr.

Changed in bzr-email:
importance: Undecided → Wishlist
status: New → Triaged
Changed in bzr:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.