Oops when submitting translations while in read-only mode

[Jeroen T. Vermeulen]

Submitting translations while the system is in read-only mode can lead to an assertion failure. A user might legitimately do this if the system went read-only after the user loaded the +translate page.

POTMsgSet._isTranslationMessageASuggestion asserts that either the message is_imported (not the case for a web submission), or the user has editing rights, or the user is allowed to make suggestions. That very last condition returns False during read-only mode. Presumably there'd be some other failure if the user did have review privileges.

It'd be helpful if the browser code checked for read-only mode as part of validating the POST, and showed an appropriate notice. In fact this sounds like it should be a standard validation check for Launchpad forms.

OOPS-1488EB320

[Jeroen T. Vermeulen (jtv)]

Just checked with stub and yes, it's a standard validation check for Launchpad forms. But read-only mode is a state that's signaled outside of the database, meaning that it can occasionally hit a request that's already past validation and in processing.