LP Bugs YUI module naming conventions

Bug #513265 reported by Edwin Grubbs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Deryck Hodge

Bug Description

Please fix the following inconsistencies between module directories,
module names, and namespaces as described in the JavascriptReviewNotes.

https://dev.launchpad.net/JavaScriptReviewNotes#Naming%20Javascript%20Modules%20and%20Namespaces

Also, please run ./bin/jslint on the modified javascript files.

c/l/javascript/bugs/subscriber.js:
    YUI.add('lp.subscriber', function(Y) {
        Y.namespace('lp');
        Y.lp.Subscription = Subscription;
        Y.lp.Subscriber = Subscriber;

    For example, you should change the above code to:
        YUI.add('bugs.subscriber', function(Y) {
            var module = Y.namespace('bugs.subscriber');
            module.Subscription = function() {...
            module.Subscriber = function() {...

c/l/javascript/bugs/filebug-dupefinder.js:
    YUI.add('bugs.dupe_finder', function(Y) {
        var bugs = Y.namespace('bugs');
        Y.bugs.setup_dupes = function() {
        Y.bugs.setup_dupe_finder = function() {

c/l/javascript/bugs/bug_tags_entry.js:
    YUI.add('bugs.bug_tags_entry', function(Y) {
        var bugs = Y.namespace('bugs');

c/l/javascript/bugs/bugtask-index.js:
    YUI.add('bugs.bugtask_index', function(Y) {
        var bugs = Y.namespace('bugs');
        Y.bugs.portlet = new PortletTarget();
        Y.bugs.setup_bugtask_index = function() {
        Y.bugs.load_subscribers_portlet = function(

c/l/javascript/bugs/offical_bug_tags.js:
    YUI.add('bugs.official_bug_tag_management', function(Y) {
        var bugs = Y.namespace('bugs');

Tags: lp-bugs qa-ok

Related branches

Deryck Hodge (deryck)
Changed in malone:
status: Triaged → In Progress
assignee: nobody → Deryck Hodge (deryck)
Deryck Hodge (deryck)
Changed in malone:
milestone: none → 10.06
Deryck Hodge (deryck)
Changed in malone:
status: In Progress → Fix Committed
Deryck Hodge (deryck)
tags: added: qa-ok
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
tags: added: qa-needstesting
removed: qa-ok
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.