Registry YUI module naming conventions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Edwin Grubbs |
Bug Description
Please fix the following inconsistencies between module directories,
module names, and namespaces as described in the JavascriptRevie
https:/
Also, please run ./bin/jslint on the modified javascript files.
Put lp/dragscroll.js into a module.
c/l/javascript/
YUI.
For example, the above code should be changed to:
var module = Y.namespace(
c/l/javascript/
YUI.
var self = Y.namespace(
c/l/javascript/
YUI.
var module = Y.namespace(
c/l/javascript/
YUI.
var module = Y.namespace(
c/l/javascript/
YUI.
var milestoneoverlay = Y.namespace(
c/l/javascript/
YUI.
var mapping = Y.namespace(
Related branches
- Abel Deuring (community): Approve (code)
-
Diff: 937 lines (+240/-224)18 files modifiedlib/canonical/launchpad/javascript/lp/dragscroll.js (+132/-122)
lib/canonical/launchpad/javascript/lp/mapping.js (+34/-34)
lib/canonical/launchpad/javascript/lp/picker.js (+4/-4)
lib/canonical/launchpad/javascript/registry/milestoneoverlay.js (+5/-5)
lib/canonical/launchpad/javascript/registry/milestonetable.js (+35/-27)
lib/canonical/launchpad/javascript/registry/tests/milestone_table.html (+5/-5)
lib/canonical/launchpad/javascript/registry/tests/test_milestone_table.js (+3/-3)
lib/canonical/launchpad/javascript/registry/tests/timeline-iframe.html (+4/-4)
lib/canonical/launchpad/javascript/registry/tests/timeline.html (+2/-1)
lib/canonical/launchpad/javascript/registry/tests/timeline.js (+1/-1)
lib/lp/app/templates/base-layout-macros.pt (+2/-0)
lib/lp/registry/browser/__init__.py (+4/-4)
lib/lp/registry/browser/tests/productrelease-views.txt (+1/-1)
lib/lp/registry/browser/tests/productseries-views.txt (+3/-3)
lib/lp/registry/templates/distroseries-index.pt (+0/-3)
lib/lp/registry/templates/object-timeline-graph.pt (+3/-2)
lib/lp/registry/templates/productrelease-add-from-series.pt (+2/-2)
lib/lp/registry/templates/productseries-index.pt (+0/-3)
tags: | added: tech-debt |
Changed in launchpad-registry: | |
status: | Triaged → In Progress |
tags: | added: qa-ok |
Landed in rev10317 in devel.