Registry YUI module naming conventions

Bug #513260 reported by Edwin Grubbs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Edwin Grubbs

Bug Description

Please fix the following inconsistencies between module directories,
module names, and namespaces as described in the JavascriptReviewNotes.

https://dev.launchpad.net/JavaScriptReviewNotes#Naming%20Javascript%20Modules%20and%20Namespaces

Also, please run ./bin/jslint on the modified javascript files.

Put lp/dragscroll.js into a module.

c/l/javascript/lp/picker.js:
    YUI.add('lp.picker', function(Y) {
        Y.namespace('lp.picker');
        Y.lp.picker.addPickerPatcher = function (
        Y.lp.picker.create = function (vocabulary, save, config) {

    For example, the above code should be changed to:
        YUI.add('lp.picker', function(Y) {
            var module = Y.namespace('lp.picker');
            module.addPickerPatcher = function (
            module.create = function (vocabulary, save, config) {

c/l/javascript/registry/milestone_table.js:
    YUI.add('lp.milestonetable', function(Y) {
        var self = Y.namespace('lp.milestonetable');

c/l/javascript/registry/team.js:
    YUI.add('registry.team', function(Y) {
        var module = Y.namespace('registry.team');

c/l/javascript/registry/timeline.js:
    YUI.add('registry.timeline', function(Y) {
        var module = Y.namespace('registry.timeline');

c/l/javascript/registry/milestoneoverlay.js:
    YUI.add('lp.milestoneoverlay', function(Y) {
        var milestoneoverlay = Y.namespace('lp.milestoneoverlay');

c/l/javascript/lp/mapping.js:
    YUI.add('lp.mapping', function(Y) {
        var mapping = Y.namespace('lp.mapping');

Related branches

Curtis Hovey (sinzui)
tags: added: tech-debt
Changed in launchpad-registry:
status: Triaged → In Progress
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Landed in rev10317 in devel.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 513260 Fix released

Fixed released in launchpad-project 10.02.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.