Options dialog should be bigger

Bug #513108 reported by Gareth White
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Explorer
Fix Released
Low
Unassigned

Bug Description

On Windows XP with the default theme, Bazaar Explorer's options dialog is slightly too narrow and looks a bit strange. If it was a few pixels wider than the third tab wouldn't need to be partially hidden.

Tested with Bazaar Explorer 0.11.2 on Windows XP SP 3.

Related branches

Revision history for this message
Gareth White (gwhite-deactivatedaccount) wrote :
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Should be a simple fix

Changed in bzr-explorer:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Could you try this on a later version of Qt. I smell a bug in that layer.

Revision history for this message
Gareth White (gwhite-deactivatedaccount) wrote :

I tried it with PyQt 4.7 and Qt 4.6.1 and the problem is worse (see attachment).

The original was with PyQt 4.4.3 and Qt 4.4.1, using the same version of Explorer and QBzr. So it does point towards the bug being in Qt.

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote : Re: [Bug 513108] Re: Options dialog should be bigger

Gareth White wrote:
> I tried it with PyQt 4.7 and Qt 4.6.1 and the problem is worse (see
> attachment).
>
> The original was with PyQt 4.4.3 and Qt 4.4.1, using the same version of
> Explorer and QBzr. So it does point towards the bug being in Qt.

We should be able to provide a simple patch to fix this but I need you
to tell me what works. Can you try some hard-coded sizes? Add something like

  self.resize(500, 400)

to the __init__ method (line 196 say) in explorer_preferences.py. If you
can suggest width and height values that work, I'll use them (on Windows).

Ian C.

Revision history for this message
Gareth White (gwhite-deactivatedaccount) wrote :

Adding the following after the call to self._build_ui(title) seems to do the trick:

        self.adjustSize()
        self.resize(self.size().width() + 50, self.size().height())

Hopefully this won't make it look too wide on other platforms!

Revision history for this message
Gareth White (gwhite-deactivatedaccount) wrote :

This Qt bug could be related, although it's talking about the height rather than the width: http://bugreports.qt.nokia.com/browse/QTBUG-3855

Changed in bzr-explorer:
assignee: nobody → Gareth White (gwhite)
importance: Medium → Low
milestone: none → 1.0.0rc1
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.