Fix &hellip issue in truncation on carousel

Bug #512886 reported by George
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Library
Fix Released
Medium
Anand Chitipothu

Bug Description

In the carousel, we're getting … dumped out on screen. It should be "...".

Here's an example:
Is President John F. Kennedy alive-- and…

on this page:
http://upstream.openlibrary.org/subjects/people/john_f._kennedy_1917-1963

It's happening on both title & author fields.

Revision history for this message
George (george-archive) wrote :

Somewhat related - we don't need to truncate titles in the history view. Since it's a table layout, they can be as long as they are. Please remove truncation there.

Changed in openlibrary:
assignee: nobody → Lance Arthur (lance-arthur)
milestone: none → upstream
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Lance Arthur (lance-arthur) wrote :

I changed this in utils.js but Anand switched it back, so I assume he has another solution in mind. I will defer to his change. http://upstream.openlibrary.org/js/utils.js?b=9&m=diff

Revision history for this message
Lance Arthur (lance-arthur) wrote :

Truncation of page names has been removed in recent history tables.

George (george-archive)
Changed in openlibrary:
assignee: Lance Arthur (lance-arthur) → Anand Chitipothu (anandology)
Revision history for this message
Lance Arthur (lance-arthur) wrote :

I went back and did the switch again.

Changed in openlibrary:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.