Launchpad itself

edit-packaging page appears not to work

Bug #512820 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Edwin Grubbs
Launchpad itself 10.02

Bug Description

This is just a UI glitch I think.

See https://edge.launchpad.net/ubuntu/+source/bluez/, the jaunty 'set
upstream link' takes you to a page with a sensible link already set (the
derived one from intrepid). Clicking 'change' on that page goes to the
server, does stuff, and then returns back to the 'edit packaging' page
again - and going back to .../bluez/ it still shows as unset.

So showing it as set (or not needing to be set) would fix this, as would
actually changing it.

 affects soyuz

Related branches

lp:~edwin-grubbs/launchpad/bug-99395-linking-sourcepackages-to-projects
Brad Crittenden (community): Approve (code)
Diff: 473 lines (+242/-78)
7 files modified
lib/canonical/launchpad/webapp/launchpadform.py (+6/-0)
lib/lp/bugs/stories/bug-also-affects/xx-also-affects-upstream-default-values.txt (+3/-2)
lib/lp/registry/browser/sourcepackage.py (+134/-46)
lib/lp/registry/browser/tests/sourcepackage-views.txt (+68/-22)
lib/lp/registry/stories/distribution/xx-distribution-packages.txt (+11/-1)
lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt (+3/-2)
lib/lp/registry/templates/sourcepackage-edit-packaging.pt (+17/-5)
Julian Edwards (julian-edwards)
affects: soyuz → launchpad-registry
Revision history for this message
Curtis Hovey (sinzui) wrote :

https://edge.launchpad.net/ubuntu/jaunty/+source/bluez clearly shows it is linked. When I change the value, I am correctly set the the distroseries+source page. When I keep the value, the page reloads. This is puzzling because I added a rule that it is correct to submit the same data as a non-update. I think the next_url rule is broken.

Changed in launchpad-registry:
status: New → Triaged
importance: Undecided → High
milestone: none → 10.02
tags: added: package-link
Changed in launchpad-registry:
importance: High → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

Edwin. I suspect recent refactoring broke this. A non-change should be accepted, we just exit the action early and go to the next_url

Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 512820 Fix released

Fixed released in launchpad-project 10.02.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.