Limit the number of edition covers displayed in the pop-up for choosing a Work cover

[George]

Example:

http://upstream.openlibrary.org/works/OL112738W/Enten-eller

1. We should add the "Manage Covers" link underneath the Work cover placeholder/image.
2. It should open up the standard cover UI
3. It should show any/all edition covers in the Manage tab
4. Modifications/Uploads should be noted in the Work history

Lance - perhaps you could place the "Manage Covers" link on the Work page, hook in the UI, then pass to Anand to code?

Also, we should standardize on the language for covers/images. Ideally, if there is no cover/author photo, we should show "Add Cover Image" OR "Add Author Photo". If there are covers/images, we should show "Manage Covers/Manage Author Photos" or something.

[George (george-archive)]

It would be super nice if we could do this for the launch of Upstream to WWW, but I don't know how hard that is :)

[Lance Arthur (lance-arthur)]

I merely inserted the same code from the author page for its image. I also changed the label language as spec'd. Currently, I don't think the pop-up can determine if it should open in Add or Manage mode, it will always open in Add mode.

[George (george-archive)]

This will be important. Confusing if we don't provide it.

[Anand Chitipothu (anandology)]

George and I discussed over skype and thought that it is better to allow people to pick edition-derived covers from the Add tab.

That sounds a lot easier to handle :)
[04/02/10 10:48:42 AM] George Oates: "Or, choose from existing covers"
[04/02/10 10:48:56 AM] George Oates: maybe, we could add it as a third option on the Add tab
[04/02/10 10:49:23 AM] George Oates: then, if you add that cover (of an edition) at the Add stage, we could add a new, separate connection to that cover image
[04/02/10 10:49:36 AM] George Oates: which could be deleted without effect on the edition...
[04/02/10 10:49:38 AM] George Oates: ?
[04/02/10 10:50:00 AM] Anand Chitipothu: Thats a good idea.
[04/02/10 10:50:17 AM] George Oates: let's try it

I've implemented it, but the styles need to be fixed. Lance can you please take a look?

[Lance Arthur (lance-arthur)]

I extended the floater by 100px to accommodate the extra panel. I think this is probably a good idea, anyway, since it leaves some breathing room in the pop-up in case there are a lot of covers to sort through. The pop-up ordinarily resizes itself based on its content, but the iFrames used in the presentation are a set height and width so the pop-up can't/won't resize itself based on those dimensions.

[George (george-archive)]

If there are more than, say, 8 covers we need to handle that.

E.g. http://upstream.openlibrary.org/works/OL26130W/Rime_of_the_ancient_mariner

I'd suggest either:

1. Only show 8 covers (even if there are more), or
2. Put a mini-carousel in there.

Option 1 is certainly the path of least resistance!

[Lance Arthur (lance-arthur)]

I did some CSS adjustments to the div holding the work covers, extending its width and setting a max height, and hiding anything outside those dimensions. That allows as many as 20 covers to be displayed at a time, and the Submit button's position also adjusts according to whether that div appears or not.

On another related issue, there's a long pause to display the iframe if there are a lot of covers. The page doesn't display at all until all covers are loaded. I'm looking into solutions (a throbber interstitial or displaying the page while contents are loading).

[George (george-archive)]

Can we please load up to 20 covers and then stop?

[George (george-archive)]

Related: https://bugs.launchpad.net/openlibrary/+bug/520595

[Edward Betts (edwardbetts)]

Let's be clear. Somebody cataloging a book never needs to upload a work cover. They have an edition in their hands, they're entering information about the edition, then they upload the cover. If they want they can also make it the cover used for the work.

[Anand Chitipothu (anandology)]

The user should be able to pick a cover to display for work and delete the ones that look inappropriate.

In the approach you are proposing, there will be cover_edition to the work. It is has so many implications. What happens if the edition is moved to another work? Will the work cover gets automatically updated when the cover of the cover_edition changes? Will it happen without any entry in the history of work page?

I've noticed that you have changed the work view template to use work.cover_edition.get_cover() instead of work.get_cover(). Because of this change, it is looking as if the work cover upload has no effect. Can you please revert it?

[Lance Arthur (lance-arthur)]

Just binking George's Point #8 about limiting the number of covers loading for any work.

I inserted some code to load big covers so that a mouseover on a thumbnail will display the larger image, which means we need to load M type images rather than S type, so the load on a work like Alice in Wonderland (500+ editions) takes about a minute before the covers are loaded and the pop-up displays them given that we are attempting to load every available cover from every edition, whether we show them or not.

[Lance Arthur (lance-arthur)]

Big covers are now in place in a carousel, so the reason for limiting covers is mitigated somewhat, but there is still a long waiting period (up to a minute) for works with a lot of covers to pull.

Additionally, I have found that if a cover is selected for a work, it is removed from the list of available covers for that work. In other words, if I click cover #1 as the work cover, it becomes the new cover as planned. If I decide I liked the look of another one better and click on change covers again, cover #1 no longer appears in that list. Any subsequently selected covers are subsequently removed as well, so that the list of covers to choose from grows smaller as you select new covers.

[George (george-archive)]

Is this resolved now? Are we happy?

[George (george-archive)]

Not needed anymore since we have the carousel in place.