Separate Interpretation/Manifestation into different groups for Events and Subjects

Bug #512090 reported by Siegfried Gevatter
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
High
Markus Korn

Bug Description

Currently datamodel.Interpretation and datamodel.Manifestation contain both the ontologies for Events and for Subjects.

This is confusing in several ways:
 - In the docs (be it HTML or using Python's in-build help), as everything is mixed together.
 - In code, as it makes it impossible (without ugly hacks) to get, eg., a list of all Subject Interpretations, as they can't be separated from Event ones.
 - It just doesn't make sense.

Therefore, I propose that we separate those collections so that we have:
 - datamodel.EventInterpretation
 - datamodel.EventManifestation
 - datamodel.SubjectInterpretation
 - datamodel.SubjectManifestation

Also, while we are at it, we should consider hiding the INTERPRETATION_ID and INTERPRETATION_DOC variables, unless they are useful for something.

As this is an API break, I also propose that datamodel.Interpretation and datamodel.Manifestation should continue working (showing a DeprecationWarning) the same release as the change is done, and then dropped with the next one.

Changed in zeitgeist:
importance: Undecided → Medium
Revision history for this message
Markus Korn (thekorn) wrote :

I think we should not put much energy (and resulting API) changes into it for now, because the whole handling of `Symbols` will change once we start working on [0]. Over the last weekend I started thinking about writing a 'libzeitgeist' using vala, but one of the first annoyance was that I need to define our interpretations and manifestations over there again. I think we should start working on this spec ASAP, so we can fix two main points of this bugreport ("getting all {event/subject}interpretations/manaifestations" and "doc structure") 'by accident' ;)
Plus, everything will make much more sense.

[0] https://blueprints.edge.launchpad.net/zeitgeist/+spec/events-ontology

Revision history for this message
Seif Lotfy (seif) wrote :

I agree with markus. We should refocus on events-ontology since it might affect a bit of the datamodel. I will sit on it this weekend

Revision history for this message
Siegfried Gevatter (rainct) wrote :

>> Over the last weekend I started thinking about writing a 'libzeitgeist' using vala

Funny, I was about to do the same (in C) but didn't write anything because I didn't know where to start :P.

Seif Lotfy (seif)
Changed in zeitgeist:
importance: Medium → Critical
status: New → Confirmed
Seif Lotfy (seif)
Changed in zeitgeist:
importance: Critical → Undecided
importance: Undecided → High
Revision history for this message
Seif Lotfy (seif) wrote :

seems like it gonna be done with the new ontology huh?

Revision history for this message
Markus Korn (thekorn) wrote :

We implemented this kind of differentiation with the ontology branch we landed some time ago.

Changed in zeitgeist:
assignee: nobody → Markus Korn (thekorn)
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.