Stellarium

Incorrect use of StelFileMgr::getUserDir()

Bug #512045 reported by treaves
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Stellarium
Fix Released
Medium
Unassigned
Stellarium 0.10.3

Bug Description

On a Mac, there is only one thing that should be stored at getUserDir(): the preferences file. That's it. Everything else should be stored at getUsersDataDirectoryName().

Revision history for this message
treaves (treaves) wrote :

The current gtUserDir() needs to be renamed to getUserPreferencesDirectoryName() and developers should know to use getUsersDataDirectoryName() for their won needs. On a Mac, the only thing that should be in the preferences directory is the config file.

As most preferences on a Mac are plist, and Stellarium does not use this, it'd also be fine to put everything under the data directory. Right now though, some things use the correct path, and some do not. This can cause the application to crash.

Revision history for this message
Fabien Chéreau (xalioth) wrote :

I think on mac we should simply use the user data directory only. This is very confusing to have 2 different ones.

Changed in stellarium:
importance: Undecided → Medium
Revision history for this message
treaves (treaves) wrote :

That'd be fine. Better to have everything there than in the preferences directory.

However, if you want, I can get it working 'correctly'.

Fabien Chéreau (xalioth)
Changed in stellarium:
status: New → Fix Committed
milestone: none → 0.10.3
Fabien Chéreau (xalioth)
Changed in stellarium:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.