gajim fails to open context menu for contacts

[Marc D.]

Binary package hint: gajim

gajim fails to open the context menu for contacts, aparrently because of a misspelled function call (again):

Traceback (most recent call last):
  File "/usr/share/gajim/src/roster_window.py", line 3121, in on_roster_treeview_button_press_event
    return self.show_treeview_menu(event)
  File "/usr/share/gajim/src/roster_window.py", line 5798, in show_treeview_menu
    self.show_appropriate_context_menu(event, iters)
  File "/usr/share/gajim/src/roster_window.py", line 5776, in show_appropriate_context_menu
    self.make_contact_menu(event, iters[0])
  File "/usr/share/gajim/src/roster_window.py", line 5387, in make_contact_menu
    menu = gui_menu_builder.get_contact_menu(contact, account)
  File "/usr/share/gajim/src/gui_menu_builder.py", line 326, in get_contact_menu
    manage_contact_menuitem, convert_to_gc_menuitems):
NameError: global name 'convert_to_gc_menuitems' is not defined

A fix is available upstream: http://www.lagaule.org/pipermail/commits/2009-November/005815.html
…and isn’t intrusive at all.

Please include the patch.

It’s kind of funny what happens when such errors aren’t caught at compile time. Compiling is regression testing ;)

[Jonathan Michalon (johndescs)]

Hi,

You don't provide version informations… what's the point of that issue now? Any update that corrected your problem has hopefully been propagated?
At least there is no more "convert_to_gc_menuitems" in the 0.13.4 source code… available in maverick or from my PPA as a backport for lucid & karmic (untested). If backport solves you issue, we may release it officially as there are other solved issues…

[Marc D. (koshy)]

That was version 0.13-0ubuntu2 (lucid) back then. I patched my version locally. Oddly enough, I can no longer reproduce the problem after reinstalling the same version of gajim from lucid.

So this problem is "fixed" (probably by an upgraded version of some library).

Your backport, by the way, works well.