RecordingSlave is missing some methods from BuilderSlave
Bug #509383 reported by
William Grant
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Julian Edwards | ||
Bug Description
RecordingSlave.
The purpose of BuilderSlave should probably be rethought, and the missing method fixed somehow.
This prevents private builds from being dispatched.
Related branches
lp:~julian-edwards/launchpad/missing-slave-method-bug-509383
- Brad Crittenden (community): Approve (code)
-
Diff: 107 lines (+28/-13)5 files modifiedlib/lp/buildmaster/manager.py (+4/-0)
lib/lp/buildmaster/model/builder.py (+2/-2)
lib/lp/buildmaster/tests/test_manager.py (+17/-6)
lib/lp/soyuz/model/binarypackagebuildbehavior.py (+2/-2)
lib/lp/soyuz/tests/soyuzbuilddhelpers.py (+3/-3)
| Changed in soyuz: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| milestone: | none → 10.01 |
| description: | updated |
| tags: | added: ppa soyuz-build |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Julian Edwards (julian-edwards) |
| tags: | added: wellington |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #3 |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #4 |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
BuilderSlave and RecordingSlave are doing the same thing, essentially. We should combine them. In the meantime, I'm fixing this bug by adding the missing method.