unable to select multiple reviewers at once on merge proposal page

[Karl Fogel]

When creating a merge proposal, for example here...

  https://code.edge.launchpad.net/~kfogel/launchpad/509194-506514-bug-heat-db-fixes/+register-merge

...you can only request one reviewer. However, *after* you've created the merge proposal, you can go back and add more reviewers, by clicking on the "Request another review" link on the merge proposal page:

  https://code.edge.launchpad.net/~kfogel/launchpad/509194-506514-bug-heat-db-fixes/+merge/17597

Sometimes you know from the outset that you want to submit to more than one reviewer. The UI for creating the merge proposal should make this possible; otherwise the user has to create the proposal and then immediately go back to it and add the other reviewer(s).

PROPOSAL:

If the lower-level component (that manages the text field where one enters the reviewer) could accept multiple names, separated by commas, then the problem would be solved for requesting reviewers and for other things. Perhaps this bug report should be filed against that lower-level component, in fact. But note that there would still need to be a UI change specific to merge proposals -- the field that says

 Reviewer: (Optional)
 (Choose...)
 A person who you want to review this.

would need to say "Reviewers" or something.

FURTHER BUG IN CURRENT BEHAVIOR:

Currently, if you try submitting two reviewers (we tried the string "adeuring, kfogel"), you get brought back to the create-a-merge-proposal page with a big red "There is 1 error." notice at the top. However, since the error in question is in the "Extra options" section below, and that section is hidden by default, you cannot see the specific error until you unfold the Extra Options section!

Proposal: When there's an error, and the error is in a hidden-by-default element, that element should be unfolded when the error page is being shown. (And this should probably be filed as a separate bug, but Abel and I have to stop this cycle of violence somewhere and get back to development! Feel free to break it out into its own bug.)

[Tim Penhey (thumper)]

It was always the plan to have an ajax ability to add extra reviewers at the creation phase.