account_tax_include is broken

[Nicolas Bessi - Camptocamp]

In V5.2 Account tax includes on change signature are not anymore good, By the way this module that allows to do tax included invoice (really important point) does not seems to have follow the evolution of his father account. Particularly the multi-currency part. It appear this module need a partial (maybe a total) rewriting.

Regards

Nicolas

[JMA(Open ERP) (jma-openerp)]

Hello Nicolas Bessi ,

I am unable to understand the problem. Could you please elaborate it with a suitable example.

Thank you.

[Borja López Soilán (NeoPolus) (borjals)]

JMA, probably the problem is pretty similar to bug 603100: the *_tax_include modules must overwrite the amount/total fields of the orders/invoices and lines so it can extend the (function field) methods.

If the field definition is not updated when the original one is, things like bug 603100 may happen.

For example, the price_subtotal on the account module was originally like this:

        'price_subtotal': fields.function(_amount_line, method=True, string='Subtotal',store=True, type="float"),

And like this on the account_tax_include module:
        'price_subtotal': fields.function(_amount_line2, method=True, string='Subtotal w/o tax', multi='amount',
            store={'account.invoice':(_get_invoice,['price_type'],10), 'account.invoice.line': (lambda self,cr,uid,ids,c={}: ids, None,10)}),

Was changed to this on the account module:

        'price_subtotal': fields.function(_amount_line, method=True, string='Subtotal', type="float",
            digits_compute= dp.get_precision('Account'), store=True),

But the account_tax_include didn't got updated so, when that module is installed, you lose the digits_compute attribute of the field.

Thats just one small example, as Nicolas states a lot of changes on multi-currency handling have been performed on the account module, but haven't been replicated to the (methods overwritten by the) account_tax_include module.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Nicolas,

In Trunk, account_tax_include has been removed and it has been added as a base functionality, so there would be no issue of accuracy now.
I am closing the bug.

Let us be aware about any issue if still persists.

Thanks.