ValueError: need more than 2 values to unpack

[Martin Schaaf]

Please include the following details in your bug report:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/beeseek/web/servers/baseserver.py", line 188, in serve_request
    method(client, requestdata)
  File "/usr/lib/pymodules/python2.6/beeseek/web/servers/http.py", line 211, in process_request
    client, host, method, page, clientheaders, httpver)
  File "/usr/lib/pymodules/python2.6/beeseek/web/servers/http.py", line 293, in _send_page_from_host
    (status, reason, httpver), serverheaders = host.read_response()
  File "/usr/lib/pymodules/python2.6/beeseek/web/protocols/http.py", line 296, in read_response
    statusline = self._read_status_line()
  File "/usr/lib/pymodules/python2.6/beeseek/web/protocols/http.py", line 126, in _read_status_line
    version, status, reason = data.split(' ', 2)
ValueError: need more than 2 values to unpack
OOPS: HPC-4B5321FF

[Martin Schaaf (mascha)]

The error comes on opening this site: http://www.dswillis.com/uxcrank/#details

[Andrea Corbellini (andrea.corbellini)]

Thank you for your help. I can confirm the issue.

[Martin Schaaf (mascha)]

The response from this server is 'HTTP/1.1 301\r\n'

Here is my fix for it:

Change in http.py line 126
from

version, status, reason = data.split(' ', 2)

to

try:
      version, status, reason = data.split(' ', 2)
except:
      version, status = data.split(' ')
      reason = ''

This fixes the problem for me.

[Andrea Corbellini (andrea.corbellini)]

On Tue, 2010-01-19 at 20:12 +0000, Martin Schaaf wrote:
> The response from this server is 'HTTP/1.1 301\r\n'

That's strange because according to the protocol specification [1] the
reason phrase must be included. However, if there's a server that sends
such responses, the proxy must be able to handle them correctly.

> Here is my fix for it:
>
> Change in http.py line 126
> from
>
> version, status, reason = data.split(' ', 2)
>
> to
>
> try:
> version, status, reason = data.split(' ', 2)
> except:
> version, status = data.split(' ')
> reason = ''

Thank you for providing a patch! There are just few things to fix. If
you want, you can create a code branch and propose a merge request.
Else, if you don't have the time to do so, I can merge and fix your
changes directly.

Feel free to ask if you need some help.

[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec6.html#sec6.1

[Andrea Corbellini (andrea.corbellini)]

Fixed in revision 417.