checkbox disk_bench_test should not hardcode the hard drive
Bug #507943 reported by
Dave Morley
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| checkbox (Ubuntu) |
Fix Released
|
Low
|
Carl Milette | ||
Bug Description
Binary package hint: checkbox
In the test script for disk_bench_test it should not hardcode the hard drive to sda. (here is the line output = Popen('hdparm -tT /dev/sda',)
the reason is vda is used for virtual drives and there maybe 2 drives in the system with ubuntu on the second.
It would be better to get the output for the disks to check from mtab or the mount command, thus ensuring that the test will work in all install circumstances and the correct hard drives.
Related branches
lp:~carl-milette/checkbox/507943
- Jeff Lane : Approve
-
Diff: 57 lines (+16/-27)2 files modifiedjobs/disk.txt.in (+16/-9)
scripts/disk_bench_test (+0/-18)
Revision history for this message
| Dave Morley (davmor2) wrote | #1 |
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | #2 |
| summary: |
- checkbox disk_bench_test should hardcode the hard drive + checkbox disk_bench_test should not hardcode the hard drive |
| Changed in checkbox (Ubuntu): | |
| status: | New → Confirmed |
| Changed in checkbox (Ubuntu): | |
| importance: | Undecided → Low |
| Changed in checkbox (Ubuntu): | |
| assignee: | nobody → Carl Milette (carl-milette) |
| Changed in checkbox (Ubuntu): | |
| status: | Confirmed → Fix Committed |
| Changed in checkbox (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I may add a patch if I can figure out what to do.
Otherwise knock yourselves out :)