findBuildCandidate() doesn't work for recipe builds
Bug #507782 reported by
Julian Edwards
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Muharem Hrnjadovic |
Bug Description
findBuildCandid
Related branches
lp:~al-maisan/launchpad/empty-table-507782
- Canonical Launchpad Engineering: Pending requested
-
Diff: 359 lines (+120/-38)8 files modifiedlib/lp/buildmaster/interfaces/buildfarmjob.py (+17/-11)
lib/lp/buildmaster/model/builder.py (+3/-9)
lib/lp/buildmaster/model/buildfarmjob.py (+1/-1)
lib/lp/buildmaster/tests/test_builder.py (+66/-6)
lib/lp/soyuz/configure.zcml (+3/-0)
lib/lp/soyuz/model/buildpackagejob.py (+5/-5)
lib/lp/soyuz/model/sourcepackagerecipebuild.py (+8/-5)
lib/lp/testing/factory.py (+17/-1)
Changed in soyuz: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
_findBuildCandi ate() subqueries returned by spefic job classes may fail the overall query if any of the tables in the resulting FROM clause is empty.
The fix needs to make sure that the overall query is not rendered invalid by empty tables listed in the FROM clause.