Stop writing ID and blank table of contents

Bug #507274 reported by George
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Library
Fix Released
High
Anand Chitipothu

Bug Description

From Edward:

this edit didn't change anything
we should stop 'id' from appearing on the diff page
and stop adding a blank table of contents when a book is edited on production
http://upstream.openlibrary.org/books/OL4500388M/?b=3&a=2&m=diff

Tags: diff
Revision history for this message
George (george-archive) wrote :

Somewhat related to the incrementing edition count problem.

Changed in openlibrary:
assignee: nobody → Anand Chitipothu (anandology)
importance: Undecided → High
importance: High → Medium
status: New → Confirmed
Revision history for this message
George (george-archive) wrote :

Blank diffs are really weird.

http://upstream.openlibrary.org/books/OL10244149M/Grammar_Activities?m=diff&b=2

You need to stop creating blank TOC, it seems?

Changed in openlibrary:
milestone: none → upstream-to-www
Revision history for this message
George (george-archive) wrote :

This is another weird one: http://upstream.openlibrary.org/books/OL12214772M/Escape_The_Expense?b=5&a=4&_compare=Compare&m=diff

Shouldn't it write out the values that we've added (even if it was a system-generated edit) ?

George (george-archive)
Changed in openlibrary:
milestone: upstream-to-www → general-bucket
importance: Medium → High
George (george-archive)
tags: added: diff
Revision history for this message
Anand Chitipothu (anandology) wrote :

The blank TOC problem was from pre-upstream code. The ID is no more written to new saves and it is not displayed in the diff for the old records.

Changed in openlibrary:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.