Can't delete authors with connected editions

Bug #506710 reported by George
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Open Library
In Progress
Medium
Anand Chitipothu

Bug Description

Just tried to delete this record:

http://upstream.openlibrary.org/authors/OL6774485A/NOOB_KING_D

Instead of deleting it, it appeared to SAVE it instead.

http://upstream.openlibrary.org/authors/OL6774485A/NOOB_KING_D?m=history

George (george-archive)
Changed in openlibrary:
assignee: nobody → Anand Chitipothu (anandology)
milestone: none → upstream-to-www
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Lance Arthur (lance-arthur) wrote :

My bad.

This is due to the dialog that pops-up after hitting delete. The script calls an action document.forms[0].submit if you click yes, but that simply submits the form. The "Delete" action is linked to a button with a type="submit" but it's not a submit, so I'm not sure what to tell the script to execute when you verify you want to delete something. Anand, how does the delete button tell the form/site to delete the record, and how do I communicate that to the button on the pop-up?

Revision history for this message
Lance Arthur (lance-arthur) wrote :

On second thought, I guess it's only sort of "my bad" since I have removed the pop-up but I still couldn't delete the above author record. So... not sure about this one.

Revision history for this message
George (george-archive) wrote :

Admins should be able to delete author records. Particularly junk entries with no books attached.

Like this one:

http://upstream.openlibrary.org/authors/OL6781721A/POOPER

Revision history for this message
Winnie (winnie-archive) wrote :

Not being able to delete author page is holding me back on completing fixing the list of author names from george/edward. Need this bug fixed in order to finish project.

Revision history for this message
George (george-archive) wrote :

So, to be clear:

 * Admins should be able to delete authors with 0 Works associated with them
 * Not Admins should not see the delete button (although we may expand this permission later)
 * Deletions should be noted in the record history

 * We should consider displaying the Page Type dropdown for Admins only on the Author page so we can manage redirects if we need to

Changed in openlibrary:
importance: Medium → High
Revision history for this message
George (george-archive) wrote :

Anand - I'm increasing this priority - it's important for us to be able to clean up bad author records as soon as we find them. Can you take a look at this next? (After you've completed your work on the Subject page?)

Changed in openlibrary:
importance: High → Critical
Revision history for this message
George (george-archive) wrote :
Revision history for this message
Anand Chitipothu (anandology) wrote :

Fixed and deleted the above mentioned author records.

Changed in openlibrary:
status: Confirmed → Fix Released
George (george-archive)
Changed in openlibrary:
milestone: upstream-to-www → general-bucket
Revision history for this message
George (george-archive) wrote :

Hi Anand,

Delete doesn't seem to work. A message pops up when I press the delete button here:

http://openlibrary.org/authors/OL6736216A/lenny_lauster/

It says "Deleting author pages not allowed."

(We need to be able to delete authors. What am I missing?)

Changed in openlibrary:
status: Fix Released → In Progress
importance: Critical → Medium
summary: - Author delete button not working
+ Can't delete authors with connected editions
Revision history for this message
Edward Betts (edwardbetts) wrote :

Deleting authors checks if there are any existing editions or works, if so it gives this error: "Deleting author pages is not allowed."

It could be clearer that you need to delete all editions and works first.

The is no obvious way to get a list of editions that link to an author.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.