Generalise buildergroup status handling
Bug #506239 reported by
Michael Nelson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
William Grant | ||
Bug Description
Currently the builder status handlers in lib/lp/
updatebuild_WAITING then calls BuilderGroup.
all of which need to be generalisable.
The plan is to consolidate all of updatebuild_* on the build behaviors, with BuilderGroup.
We can do the refactoring in two steps, first leaving a BuilderGroup.
Related branches
lp:~wgrant/launchpad/common-build-ancestor
- Julian Edwards (community): Approve
-
Diff: 1036 lines (+450/-383)9 files modifiedlib/canonical/launchpad/interfaces/_schema_circular_imports.py (+3/-0)
lib/lp/buildmaster/buildergroup.py (+9/-310)
lib/lp/buildmaster/interfaces/buildbase.py (+89/-0)
lib/lp/buildmaster/model/buildbase.py (+130/-0)
lib/lp/soyuz/configure.zcml (+8/-0)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+1/-1)
lib/lp/soyuz/interfaces/build.py (+3/-63)
lib/lp/soyuz/interfaces/buildpackagejob.py (+0/-5)
lib/lp/soyuz/model/build.py (+207/-4)
lp:~wgrant/launchpad/updatebuild-to-build-behavior
- Julian Edwards (community): Approve
-
Diff: 406 lines (+127/-119)11 files modifiedlib/lp/buildmaster/buildergroup.py (+2/-96)
lib/lp/buildmaster/interfaces/buildbase.py (+1/-1)
lib/lp/buildmaster/interfaces/builder.py (+6/-2)
lib/lp/buildmaster/interfaces/buildfarmjobbehavior.py (+7/-0)
lib/lp/buildmaster/model/builder.py (+4/-0)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+99/-0)
lib/lp/soyuz/configure.zcml (+0/-8)
lib/lp/soyuz/doc/buildd-slave.txt (+1/-1)
lib/lp/soyuz/interfaces/build.py (+0/-4)
lib/lp/soyuz/interfaces/buildpackagejob.py (+5/-0)
lib/lp/soyuz/model/binarypackagebuildbehavior.py (+2/-7)
lp:~michael.nelson/launchpad/move_updatebuild_calls
- Julian Edwards (community): Approve
-
Diff: 294 lines (+33/-43)10 files modifiedlib/lp/buildmaster/buildergroup.py (+1/-13)
lib/lp/buildmaster/interfaces/builder.py (+2/-2)
lib/lp/buildmaster/manager.py (+1/-1)
lib/lp/buildmaster/master.py (+2/-7)
lib/lp/buildmaster/model/buildbase.py (+1/-1)
lib/lp/buildmaster/model/builder.py (+9/-3)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+1/-1)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+14/-13)
lib/lp/soyuz/tests/soyuzbuilddhelpers.py (+1/-1)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+1/-1)
lp:~wgrant/launchpad/move-remaining-updatebuild-methods
- Julian Edwards (community): Approve
-
Diff: 1770 lines (+637/-579)25 files modifieddatabase/sampledata/current.sql (+1/-1)
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+3/-0)
lib/lp/buildmaster/buildergroup.py (+4/-411)
lib/lp/buildmaster/interfaces/buildbase.py (+89/-0)
lib/lp/buildmaster/interfaces/builder.py (+8/-4)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+3/-0)
lib/lp/buildmaster/interfaces/buildfarmjobbehavior.py (+7/-0)
lib/lp/buildmaster/manager.py (+1/-1)
lib/lp/buildmaster/master.py (+2/-7)
lib/lp/buildmaster/model/buildbase.py (+130/-0)
lib/lp/buildmaster/model/builder.py (+12/-3)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+124/-0)
lib/lp/soyuz/doc/buildd-slave.txt (+2/-3)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+15/-14)
lib/lp/soyuz/interfaces/build.py (+3/-63)
lib/lp/soyuz/interfaces/buildqueue.py (+0/-25)
lib/lp/soyuz/model/binarypackagebuildbehavior.py (+2/-7)
lib/lp/soyuz/model/build.py (+207/-4)
lib/lp/soyuz/model/buildpackagejob.py (+4/-0)
lib/lp/soyuz/model/buildqueue.py (+3/-34)
lib/lp/soyuz/tests/soyuzbuilddhelpers.py (+1/-1)
lib/lp/soyuz/tests/test_buildpackagejob.py (+5/-0)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+1/-1)
lib/lp/translations/model/translationtemplatesbuildjob.py (+4/-0)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+6/-0)
| Changed in soyuz: | |
| milestone: | none → 10.01 |
| assignee: | nobody → William Grant (wgrant) |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #1 |
| Changed in soyuz: | |
| status: | Triaged → Fix Committed |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in devel r10174 <http://