Request: Please avoid to use underscores in message contexts

[Masato HASHIMOTO]

Please avoid to use underscores in message contexts because `msgfmt -c -v` reports warning as asynced keyboard accelerators.

Attached is a patch to replace existing underscores with space.

Regards

[jazzynico (jazzynico)]

Hi,

I'm a bit reluctant to apply this patch because on my computer, msgfmt -c -v doesn't return warnings, and I see no restriction about underscores (in the context string) in the gettext documentation.
I'm using gettext 0.17-8ubuntu2.
Could you please give your gettext version and attach a sample of your warnings?
Thanks!

Regards.

[Masato HASHIMOTO (hashimo)]

Oops, sorry, it's my fault.
Exact options are "msgfmt -c -v **--check-accelerators=_**".

The result should be as follows (in inkscape0.47):

$ LANG=C msgfmt ja.po -c -v --check-accelerators=_ -o /dev/null
ja.po:9402: msgstr lacks the keyboard accelerator mark '_'
ja.po:18559: msgstr lacks the keyboard accelerator mark '_'
ja.po:18563: msgstr lacks the keyboard accelerator mark '_'
ja.po:18573: msgstr lacks the keyboard accelerator mark '_'
ja.po:18577: msgstr lacks the keyboard accelerator mark '_'
ja.po:18587: msgstr lacks the keyboard accelerator mark '_'
ja.po:18591: msgstr lacks the keyboard accelerator mark '_'
ja.po:18609: msgstr lacks the keyboard accelerator mark '_'
ja.po:18613: msgstr lacks the keyboard accelerator mark '_'
4960 translated messages, 18 untranslated messages.

[Masato HASHIMOTO (hashimo)]

I forgot one more info.
The patch is for bzr/trunk.

Regards

[jazzynico (jazzynico)]

Fix committed in revision 9154.
Thanks for the patch!