commit: Error 123 while invoking editor

[Kirill Krasnov]

I enter in config path to external editor: "C:/Program Files/editors/SciTE/SciTE.exe". I get error 123. When I check config, I see '"C:/Program Files/editors/SciTE/SciTE.exe"'.
I delete double quote - all work fine.

[Alexander Belchenko (bialix)]

Relevant traceback from .bzr.log:

0.125 bzr arguments: [u'commit', u'--unchanged']
0.156 looking for plugins in C:/Documents and
Settings/kkrasnov/Application Data/bazaar/2.0/plugins
0.156 looking for plugins in C:/Pers/Bazaar/plugins
0.359 encoding stdout as sys.stdout encoding 'cp1251'
0.453 opening working tree 'C:/Pers/SVN/bzr/highlight/Kirill'
0.516 preparing to commit
[ 3964] 2010-01-06 22:55:37.140 INFO: Committing to:
C:/Pers/SVN/bzr/highlight/Kirill/
0.531 Selecting files for commit with filter None
0.562 check paths: None
0.578 aborting commit write group because of exception:
0.578 Traceback (most recent call last):
  File "bzrlib\commit.pyo", line 398, in _commit
  File "bzrlib\builtins.pyo", line 3106, in get_message
  File "bzrlib\msgeditor.pyo", line 151, in edit_commit_message_encoded
  File "bzrlib\msgeditor.pyo", line 64, in _run_editor
  File "subprocess.pyo", line 444, in call
  File "subprocess.pyo", line 594, in __init__
  File "subprocess.pyo", line 822, in _execute_child
WindowsError: [Error 123] ,

[ 3964] 2010-01-06 22:55:37.187 INFO: aborting commit write group:
WindowsError(123,
'\xd1\xe8\xed\xf2\xe0\xea\xf1\xe8\xf7\xe5\xf1\xea\xe0\xff
\xee\xf8\xe8\xe1\xea\xe0 \xe2 \xe8\xec\xe5\xed\xe8
\xf4\xe0\xe9\xeb\xe0,')
0.656 Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 826, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1027, in run_bzr
  File "bzrlib\commands.pyo", line 638, in run_argv_aliases
  File "bzrlib\builtins.pyo", line 3131, in run
  File "bzrlib\decorators.pyo", line 194, in write_locked
  File "bzrlib\workingtree_4.pyo", line 197, in commit
  File "bzrlib\decorators.pyo", line 194, in write_locked
  File "bzrlib\mutabletree.pyo", line 225, in commit
  File "bzrlib\commit.pyo", line 257, in commit
  File "bzrlib\cleanup.pyo", line 117, in run
  File "bzrlib\cleanup.pyo", line 147, in _do_with_cleanups
  File "bzrlib\commit.pyo", line 398, in _commit
  File "bzrlib\builtins.pyo", line 3106, in get_message
  File "bzrlib\msgeditor.pyo", line 151, in edit_commit_message_encoded
  File "bzrlib\msgeditor.pyo", line 64, in _run_editor
  File "subprocess.pyo", line 444, in call
  File "subprocess.pyo", line 594, in __init__
  File "subprocess.pyo", line 822, in _execute_child
WindowsError: [Error 123] ,

0.656 return code 3

[Martin Pool (mbp)]

error 123 seems to be http://support.microsoft.com/kb/318746 "The Filename, Directory Name, or Volume Label Syntax Is Incorrect

So I would suspect your editor is set to something strange.

We should at least be showing the command we're trying to run and giving a better message.

[Martin Pool (mbp)]

Sorry, I just saw the description as well as the traceback.

When you say "I enter in config" do you mean you configured this through bzr explorer or qconfig, or by editing the file directly?

[Kirill Krasnov (kkrasnov)]

I edit directly.

[Martin Pool (mbp)]

2010/1/11 Kirill Krasnov <email address hidden>:
> I edit directly.

So the bug is basically:

1- we should give a decent error message saying 'failed to run "C:\blah"'
2- perhaps we should treat doublequotes in the configuration file as
surrounding a string, not being part of it?

--
Martin <http://launchpad.net/~mbp/>

[Alexander Belchenko (bialix)]

Martin Pool пишет:
> 2010/1/11 Kirill Krasnov <email address hidden>:
>> I edit directly.
>
> So the bug is basically:
>
> 1- we should give a decent error message saying 'failed to run "C:\blah"'

I guess this one will be enough to diagnose the problem on user side.
Today the error message provides no clues to understand what's going on,
and why qcommit worked but plain commit is not.

> 2- perhaps we should treat doublequotes in the configuration file as
> surrounding a string, not being part of it?

Will be nice, but IMO it's not strongly necessary.

[Kirill Krasnov (kkrasnov)]

1. In qcommit not request external editor. I see gui of bzr where I can set commit message

[Martin Pool (mbp)]

Attempted fix here:

https://code.edge.launchpad.net/~mbp/bzr/504842-subprocess-error/+merge/17189