dirstate support for changing root id is broken
Bug #504390 reported by
John A Meinel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Medium
|
John A Meinel | ||
| 2.0 |
Fix Released
|
Medium
|
John A Meinel | ||
Bug Description
In investigating bug #494269 I realized that dirstate's support for setting the root id is broken. Specifically, this fails
root_id = new_root_id
wt.set_
assert '' = wt.id2path(root_id)
^- Actually raises an exception
What is weird is that wt.path2id('') does return the new root id. But something (possibly the _id_entry cache?) is not working.
Related branches
lp:~jameinel/bzr/2.0.4-dirstate-set-root-504390
- Robert Collins (community): Approve
-
Diff: 349 lines (+147/-38)9 files modifiedNEWS (+2/-3)
bzrlib/dirstate.py (+10/-3)
bzrlib/tests/per_workingtree/test_pull.py (+13/-1)
bzrlib/tests/per_workingtree/test_set_root_id.py (+18/-2)
bzrlib/tests/per_workingtree/test_workingtree.py (+15/-1)
bzrlib/tests/test_dirstate.py (+43/-20)
bzrlib/tests/test_shelf.py (+24/-1)
bzrlib/tests/test_switch.py (+13/-1)
bzrlib/workingtree.py (+9/-6)
| Changed in bzr: | |
| milestone: | none → 2.1.0rc1 |
| Changed in bzr: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
