invalid list modteration markup breaks webkit
Bug #504024 reported by
Curtis Hovey
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Unassigned |
Bug Description
The HeldMessageView and message-
1) The template uses `structure view/author`, but the author field is not HTML. The angle brakets are not escaped, creating an unclosed tag.
2) The view's initialize() method is using `paragraphs.
Both of these errors can cause form submittal errors.
Related branches
lp:~sinzui/launchpad/wax-and-wane
Merged
into
lp:launchpad
- Brad Crittenden (community): Approve (code)
-
Diff: 296 lines (+110/-63)8 files modifiedlib/canonical/launchpad/icing/style-3-0.css (+3/-0)
lib/lp/registry/browser/mailinglists.py (+13/-4)
lib/lp/registry/browser/milestone.py (+1/-1)
lib/lp/registry/browser/tests/mailinglist-message-views.txt (+74/-0)
lib/lp/registry/browser/tests/milestone-views.txt (+15/-2)
lib/lp/registry/browser/tests/test_views.py (+1/-0)
lib/lp/registry/doc/message-holds.txt (+0/-52)
lib/lp/registry/templates/milestone-index.pt (+3/-4)
tags: | added: mailing-lists |
Changed in launchpad-registry: | |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
Fixed in launchpad-devel r10160.