Layouts \ Media doesn't appear when permission set up for group

Bug #502560 reported by hanys666
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
High
Dan Garner

Bug Description

Layout \ Media with permission set for "Group" does not show up in users list.
I've set up user as a group admin as per instructions from Answers but nothing happen, just blank.

I think the problem is when Xibo looking for groups which user belongs to. They showing up as user name but it should be group.
Whats if user belongs to 2 or more groups ? Looking at the script, getGroupFromID can have only 1 result. Which goup wil that be ?
I think the variable should be changed to array, since user can belonge to more than one group.

Related branches

Revision history for this message
hanys666 (arthur-it) wrote :

Xibo Version: 1.1.0

summary: - Layouts doesn't appear when set up for group permission
+ Layouts doesn't appear when permission set up for group
description: updated
hanys666 (arthur-it)
summary: - Layouts doesn't appear when permission set up for group
+ Layouts \ Media doesn't appear when permission set up for group
description: updated
Revision history for this message
Dan Garner (dangarner) wrote :

This seems to have been missed out of the "users can belong to more than one group" development. Should be easy to fix for 1.1.1.

Changed in xibo:
milestone: none → 1.1.1
assignee: nobody → Dan Garner (dangarner)
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Dan Garner (dangarner) wrote :

As Hanys suggested now that a user can belong to more than one group it was necessary to return an array of groupID's for each user when considering permissions.

This has highlighted a few issues that will need some discussion.

1. There is no point in having the "Group" column on the Layouts/Library as a single group cannot be resolved
2. Previously a group admin could edit media owned by any user in their group - now they can edit any media owned by any user in a group that intersects their groups - is this right?

Could do with some direction here.

Changed in xibo:
status: Confirmed → In Progress
Revision history for this message
Alex Harrington (alexharrington) wrote :

1. Should media/layouts be assigned to groups too then? We'd then show a list of groups that media is available to.
2. Umm, only if they're group admin of all those groups, then yes.

Alex

Revision history for this message
Dan Garner (dangarner) wrote :

Hmm, currently a user who is a "group admin" is admin of all the groups they are in... perhaps this is what needs to change.

I am not sure if it is worthwhile having layouts/media assigned to groups too.... i'll work on some use cases.

Dan Garner (dangarner)
Changed in xibo:
status: In Progress → Fix Committed
Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.