PDF viewer detection incorrect in OSX
Bug #501330 reported by
Xavier (Open ERP)
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Odoo GTK Client (MOVED TO GITHUB) | Status tracked in Trunk | |||||
4.2 |
Won't Fix
|
Undecided
|
Unassigned | |||
5.0 |
Fix Released
|
Medium
|
Unassigned | |||
Trunk |
Fix Released
|
Medium
|
Unassigned |
Bug Description
In the printer module (printer/
/usr/bin/open without any argument but the file name explicitly uses the default (os default or file default) application for the file, the viewer therefore shouldn't be hardcoded to Preview.
Also, specifying the full path to open shouldn't be necessary.
To post a comment you must log in.
The OS detection routine is also incorrect: it should use sys.platform whose behavior is clearly documented (and includes osx as 'darwin') instead of os.uname(). Furthermore sys.platform is available under Windows so the os.name != 'nt' wouldn't be necessary anymore