Rev. 135 Crash with Docky option enabled

Bug #500193 reported by Sebastián Porta
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
CoverGloobus
Fix Released
High
BadChoice

Bug Description

I just installed the last revision, 135, and CG crash seconds after launch if the option "Enable Covers on Docky" it's on.
I tried Banshee and Rhythmbox with the same results.
I even tried running CG without any media player running and I got the crash.
I run CG from the terminal and this is the output:

covergloobus --debug
/usr//share/locale/
[DEBUG] Theme path: /usr/share/covergloobus/themes/Ibex
[INFO] Theme: intrepid-ibex-mockup by d0od
[DEBUG] Loading AlbumCover xml info
[DEBUG] Player: Rhythmbox
[DEBUG] Theme: Ibex
[WARNING] Player not started
[DEBUG] Creating Docky
[DEBUG] Docky: Set Title
[DEBUG] Button Pressed: 3
[DEBUG] Right Button Pressed, Launch menu
[DEBUG] Player not started
[DEBUG] MENU OPTION: config
[DEBUG] Docky: Connect DBUS

I'm running Karmic, and Docky rev. 998.

Changed in covergloobus:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → BadChoice (guitarboy000)
Revision history for this message
BadChoice (guitarboy000) wrote :

Does it still happen with last rev?

Revision history for this message
Sebastián Porta (sebastianporta) wrote :

I just update to the last rev (174) and now I can't even launch CG.
Here's the output:

$ covergloobus --debug
[DEBUG] /usr//share/locale/
[DEBUG] /usr//etc
[DEBUG] Initializing dbus
[DEBUG] Disconnecting player controls
[DEBUG] Position to start: 34,510
[DEBUG] Theme Name:Coversutra
[DEBUG] Player Name:Banshee
[DEBUG] Lyrics Name:lyricswikia
[DEBUG] Tabs Name:ultimateguitar
[DEBUG] On top?:0
[DEBUG] Amazon Covers:1
[DEBUG] Docky:0
[DEBUG] Stick to desktop:1
[DEBUG] Show status icon:1
[DEBUG] Loading player
[DEBUG] Player loaded: Banshee
[DEBUG] Theme: /usr/share/covergloobus/themes/BadChoice
[DEBUG] Drawing window
[DEBUG] Theme path: /usr/share/covergloobus/themes/BadChoice
[INFO] Theme: BadChoice
[DEBUG] Loading AlbumCover xml info
[DEBUG] Theme name: Coversutra
[DEBUG] Theme path: /usr/share/covergloobus/themes/BadChoice
Traceback (most recent call last):
  File "/usr//share/covergloobus/covergloobus.py", line 634, in <module>
    sys.exit(c.main())
  File "/usr//share/covergloobus/covergloobus.py", line 97, in main
    self.init() #Init configurations
  File "/usr//share/covergloobus/covergloobus.py", line 114, in init
    self.draw_window()
  File "/usr//share/covergloobus/covergloobus.py", line 197, in draw_window
    if self.UIManager.playercontrols_item and self.player.is_playing():
  File "/usr/share/covergloobus/players/Banshee.py", line 148, in is_playing
    state = self.dbus_object.GetCurrentState()
AttributeError: 'NoneType' object has no attribute 'GetCurrentState'

Revision history for this message
BadChoice (guitarboy000) wrote :

Wich banshee version are you using?

Revision history for this message
Sebastián Porta (sebastianporta) wrote :

I'm using "Banshee 1.6 Beta 3 (1.5.2)", but I don't know if it's related.
I get the same output whether I'm running Banshee or not.
And I don't know if this helps but I'm also changed the player from the CoverGloobus.cfg to Rhythmbox and get this:

$ covergloobus --debug
[DEBUG] /usr//share/locale/
[DEBUG] /usr//etc
[DEBUG] Initializing dbus
[DEBUG] Disconnecting player controls
[DEBUG] Position to start: 34,510
[DEBUG] Theme Name:Coversutra
[DEBUG] Player Name:Rhythmbox
[DEBUG] Lyrics Name:lyricswikia
[DEBUG] Tabs Name:ultimateguitar
[DEBUG] On top?:0
[DEBUG] Amazon Covers:1
[DEBUG] Docky:0
[DEBUG] Stick to desktop:1
[DEBUG] Show status icon:1
[DEBUG] Loading player
[DEBUG] Player loaded: Rhythmbox
[DEBUG] Theme: /usr/share/covergloobus/themes/BadChoice
[DEBUG] Drawing window
[DEBUG] Theme path: /usr/share/covergloobus/themes/BadChoice
[INFO] Theme: BadChoice
[DEBUG] Loading AlbumCover xml info
[DEBUG] Theme name: Coversutra
[DEBUG] Theme path: /usr/share/covergloobus/themes/BadChoice
Traceback (most recent call last):
  File "/usr//share/covergloobus/covergloobus.py", line 634, in <module>
    sys.exit(c.main())
  File "/usr//share/covergloobus/covergloobus.py", line 97, in main
    self.init() #Init configurations
  File "/usr//share/covergloobus/covergloobus.py", line 114, in init
    self.draw_window()
  File "/usr//share/covergloobus/covergloobus.py", line 197, in draw_window
    if self.UIManager.playercontrols_item and self.player.is_playing():
  File "/usr/share/covergloobus/players/Rhythmbox.py", line 142, in is_playing
    return self.playerAPI.getPlaying()
AttributeError: 'NoneType' object has no attribute 'getPlaying'

Revision history for this message
Alexandr Grigorcea (cahr-gr) wrote :

ok, the problem comes out when CG starts and media player is not started, I fixed it in my dbus branch

Changed in covergloobus:
milestone: none → 1.6
status: Confirmed → Fix Committed
Revision history for this message
Sebastián Porta (sebastianporta) wrote :

With rev. 192 and the Docky option on, CG exits.
Here's the output:

$ covergloobus --debug
[DEBUG] /usr//share/locale/
[DEBUG] /usr//etc
[DEBUG] Initializing dbus
[DEBUG] Disconnecting player controls
[DEBUG] Position to start: 117,495
[DEBUG] Theme Name:Vinyl
[DEBUG] Player Name:Banshee
[DEBUG] Lyrics Name:absolutelyrics
[DEBUG] Tabs Name:ultimateguitar
[DEBUG] On top?:0
[DEBUG] Amazon Covers:1
[DEBUG] Docky:1
[DEBUG] Stick to desktop:0
[DEBUG] Show status icon:1
[DEBUG] Theme: /usr/share/covergloobus/themes/Vinyl
[DEBUG] Drawing window
[DEBUG] Theme path: /usr/share/covergloobus/themes/Vinyl
[INFO] Theme: Vinyl
[DEBUG] Loading AlbumCover xml info
[DEBUG] Theme name: Vinyl
[DEBUG] Theme path: /usr/share/covergloobus/themes/Vinyl
[DEBUG] Loading player
[DEBUG] Player loaded: Banshee
[DEBUG] Creating Docky
[DEBUG] Docky: Set Waiting
[DEBUG] COVER PATH:/home/seba/.cache/album-art/pinkfloyd-wishyouwerehere.jpg
[DEBUG] Docky: Set Cover: /home/seba/.cache/album-art/pinkfloyd-wishyouwerehere.jpg
Docky Not connected
[DEBUG] Docky: Set Title
[DEBUG] Docky: Unset Waiting
[INFO] Song Changed: Have A Cigar
[DEBUG] Connecting player controls
[DEBUG] Showing status icon: True
[DEBUG] Init done
[DEBUG] Docky: Connect DBUS
[ERROR] Docky: something gone wrong with docky :(

The player was started and CG was working fine without the Docky option on.

Revision history for this message
Alexandr Grigorcea (cahr-gr) wrote :

Some new icons appear at docky after pressing Save in configuration window? If yes is it CG default icon (like one you see at top of this page)? And do you have some custom CG shortcuts/icons somewhere (Gnome menu, desktop, panel, docky)?

Revision history for this message
Sebastián Porta (sebastianporta) wrote :

Yes, the CG default icon appears on Docky and then exit.
And no, I don't have any custom shortcuts anywhere.

Revision history for this message
Alexandr Grigorcea (cahr-gr) wrote :

thanks to Sebastián we found the problem
he had a CG launcher in
~/.local/share/applications/CoverGloobus.desktop
it appears when new shortcut is added to Gnome Applications menu and remains there even if the shortcut is deleted
so Docky uses ~/.local/share/applications/CoverGloobus.desktop and not /usr/share/applications/covergloobus.desktop
a better way to find CG icon on Docky is needed

Changed in covergloobus:
status: Fix Committed → Confirmed
Revision history for this message
BadChoice (guitarboy000) wrote :

Aps, really strange, what we need to do is add the icons in data like in gloobus-preview.
And then install the icon where it goes,I was waiting till we have a good icon for the app so I don't do the work twice..

Revision history for this message
Alexandr Grigorcea (cahr-gr) wrote : Re: [Bug 500193] Re: Rev. 135 Crash with Docky option enabled

the problem are not icons but *.desktop file used by Docky and we can't
really control this unless we find a way to add new elements to Docky
(impossible for now)
a different approach may be finding the icon (its d-bus path) by name and
not by *.desktop file

On Sun, Jan 24, 2010 at 2:30 PM, BadChoice <email address hidden>wrote:

> Aps, really strange, what we need to do is add the icons in data like in
> gloobus-preview.
> And then install the icon where it goes,I was waiting till we have a good
> icon for the app so I don't do the work twice..
>
> --
> Rev. 135 Crash with Docky option enabled
> https://bugs.launchpad.net/bugs/500193
> You received this bug notification because you are a member of Gloobus
> Developers, which is the registrant for CoverGloobus.
>
> Status in CoverGloobus: Confirmed
>
> Bug description:
> I just installed the last revision, 135, and CG crash seconds after launch
> if the option "Enable Covers on Docky" it's on.
> I tried Banshee and Rhythmbox with the same results.
> I even tried running CG without any media player running and I got the
> crash.
> I run CG from the terminal and this is the output:
>
> covergloobus --debug
> /usr//share/locale/
> [DEBUG] Theme path: /usr/share/covergloobus/themes/Ibex
> [INFO] Theme: intrepid-ibex-mockup by d0od
> [DEBUG] Loading AlbumCover xml info
> [DEBUG] Player: Rhythmbox
> [DEBUG] Theme: Ibex
> [WARNING] Player not started
> [DEBUG] Creating Docky
> [DEBUG] Docky: Set Title
> [DEBUG] Button Pressed: 3
> [DEBUG] Right Button Pressed, Launch menu
> [DEBUG] Player not started
> [DEBUG] MENU OPTION: config
> [DEBUG] Docky: Connect DBUS
>
> I'm running Karmic, and Docky rev. 998.
>
>
>

Revision history for this message
Alexandr Grigorcea (cahr-gr) wrote :

getting d-bus path of CG on docky should resove this

Changed in covergloobus:
status: Confirmed → Fix Committed
Revision history for this message
Alexandr Grigorcea (cahr-gr) wrote :

oops, getting by XID

Changed in covergloobus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.