stops after generating 5-6 thumbnails

[Hadmut Danisch]

Binary package hint: gnome-raw-thumbnailer

Hi,

when I open a directory with plenty of raw images with nautilus, it generates only about 4-6 thumbnails, then it stops generating thumbnails until gnome is restarted.Maybe a timeout problem.

ProblemType: Bug
Architecture: i386
Date: Tue Dec 22 22:10:04 2009
DistroRelease: Ubuntu 9.10
NonfreeKernelModules: fglrx
Package: gnome-raw-thumbnailer 2.0.1-0ubuntu6
ProcEnviron:
 LANGUAGE=en_US.UTF-8
 PATH=(custom, user)
 LANG=en_US.UTF-8
 LC_MESSAGES=en_US.utf8
 SHELL=/bin/tcsh
ProcVersionSignature: Ubuntu 2.6.31-16.53-generic
SourcePackage: gnome-raw-thumbnailer
Uname: Linux 2.6.31-16-generic i686

[Hadmut Danisch (hadmut)]

OK, I found two bugs:

- gnome-raw-thumbnailer parses Sony RAW files like TIFF files and recursively parses the TIFF-Tree-Tag 014a. However,
  Sony RAW files have these tags and the offset as described, but there seems to be no regular IFD structure at this place, but
  some different sort of data. On the other hand, gnome-raw-thumbnailer is poorly written software without any range check or
  catching error states. So it runs into an undefined loop when parsing Sony files. But when commenting out that recursive
  call, it works. (But I have no idea whether this breaks reading other file formats than Sony).

- at the end of main() there's a g_free (fname) which causes a segmentation fault. Commenting this out might leave some memory allocated, which doesn't really cause problems because the program terminates immediately. But it lets the program terminate cleanly and without segfault.

After fixing these to problems it works for me (at least for sony files). Don't know if blocking the recursion of 014a tags causes any trouble with other file formats.

regards