Local script variables missing local declaration "var"
Bug #499344 reported by
Sean M. Pappalardo
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Undecided
|
Unassigned | ||
| 1.7 |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Some of the script files are incorrectly defining local variables as globals. When you omit the "var" keyword, they're automatically made global which will clobber anything else by that name in the same ScriptEngine, even if it's from another script file.
Specifically, the Hercules RMX script has offenders in lines 41, 52-53, 61-62, 80, 106, 133, 137, 153, 176, and 183. All the other scripts need to be checked for this as well. (Except the SCS scripts, though another pair of eyes on those wouldn't hurt as well.)
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #1 |
| Changed in mixxx: | |
| status: | New → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #2 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
I believe the offending flies were fixed.